Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4860)

Unified Diff: chrome/installer/setup/uninstall.cc

Issue 10889028: Install a user-level Start Menu shortcut for every user on system-installs through Active Setup (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: remove TODO for Notify Created 8 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/installer/setup/uninstall.cc
diff --git a/chrome/installer/setup/uninstall.cc b/chrome/installer/setup/uninstall.cc
index a73a7f686f6e4125a6dd3cb4b04ba4bab559eb05..5165fef76576cbdcaee05ea22fe9681b8a6042f7 100644
--- a/chrome/installer/setup/uninstall.cc
+++ b/chrome/installer/setup/uninstall.cc
@@ -312,6 +312,18 @@ void DeleteChromeShortcuts(const InstallerState& installer_state,
VLOG(1) << "Deleting shortcut " << shortcut_path.value();
if (!file_util::Delete(shortcut_path, true))
LOG(ERROR) << "Failed to delete folder: " << shortcut_path.value();
+
+ // For system-level installs: also delete the per-user Start Menu shortcut
+ // created by the Active Setup flow.
+ // TODO (gab): This is ugly, but I have a much cleaner solution to all of
+ // this in my upcoming refactoring.
+ if (installer_state.system_install() &&
+ PathService::Get(base::DIR_START_MENU, &shortcut_path)) {
+ shortcut_path = shortcut_path.Append(product_name);
+ VLOG(1) << "Deleting shortcut " << shortcut_path.value();
+ if (!file_util::Delete(shortcut_path, true))
+ LOG(ERROR) << "Failed to delete folder: " << shortcut_path.value();
+ }
}
ShellUtil::RemoveChromeStartScreenShortcuts(product.distribution(),
@@ -1085,11 +1097,7 @@ InstallStatus UninstallProduct(const InstallationState& original_state,
ProcessOnOsUpgradeWorkItems(installer_state, product);
-// TODO(gab): This is only disabled for M22 as the shortcut CL using Active
-// Setup will not make it in M22.
-#if 0
UninstallActiveSetupEntries(installer_state, product);
-#endif
}
if (product.is_chrome_frame()) {

Powered by Google App Engine
This is Rietveld 408576698