Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2735)

Unified Diff: chrome/installer/setup/setup_main.cc

Issue 10889028: Install a user-level Start Menu shortcut for every user on system-installs through Active Setup (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: comments + exit code + create shell notify Created 8 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/installer/setup/setup_main.cc
diff --git a/chrome/installer/setup/setup_main.cc b/chrome/installer/setup/setup_main.cc
index 139b8274e9eb5c81aba8e38593fc0d1b12a05436..4c327fb776296587714c97195297bfee7cb3b76a 100644
--- a/chrome/installer/setup/setup_main.cc
+++ b/chrome/installer/setup/setup_main.cc
@@ -1093,9 +1093,20 @@ bool HandleNonInstallCmdLineOptions(const InstallationState& original_state,
DCHECK(installer_state->system_install());
const Product* chrome_install =
installer_state->FindProduct(BrowserDistribution::CHROME_BROWSER);
- DCHECK(chrome_install);
- // TODO(gab): Implement the new shortcut functionality here.
- LOG(ERROR) << "--configure-user-settings is not implemented.";
+
grt (UTC plus 2) 2012/09/01 03:20:28 please put a big honking notice here stating that
gab 2012/09/01 22:28:40 Done.
+ // Create per-user Start Menu shortcuts.
+ // TODO(gab): This should really be more involved, but for now creating
+ // the shortcut and leaving it non-updated in later updates is fine.
+ // This is all coming in an upcoming refactoring of the shortcuts, but for
+ // now this will simply create the user-level shortcut once on the first
+ // (and only) invocation of Active Setup for Chrome for this user.
+ if (chrome_install)
+ ForceCreateUserLevelStartMenuShortcut(*installer_state, *chrome_install);
+ else
+ NOTREACHED();
+
+ *exit_code = InstallUtil::GetInstallReturnCode(installer::INSTALL_REPAIRED);
+
} else if (cmd_line.HasSwitch(
installer::switches::kRegisterChromeBrowser)) {
installer::InstallStatus status = installer::UNKNOWN_STATUS;

Powered by Google App Engine
This is Rietveld 408576698