Install a user-level Start Menu shortcut for every user on system-installs through Active Setup

chrome/installer/setup/install.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/installer/setup/install.h"
 
 #include <shlobj.h>
 #include <time.h>
 #include <winuser.h>
 
@@ skipping 276 matching lines @@
 
   start_menu_folder_path = start_menu_folder_path.Append(product_name);
 
   // Create/update Chrome link (points to chrome.exe) & Uninstall Chrome link
   // (which points to setup.exe) under |start_menu_folder_path|.
 
   // Chrome link (launches Chrome)
   FilePath chrome_link(start_menu_folder_path.Append(product_name + L".lnk"));
 
   if (create_always && !file_util::PathExists(start_menu_folder_path))
-      file_util::CreateDirectoryW(start_menu_folder_path);
+    file_util::CreateDirectoryW(start_menu_folder_path);
 
   VLOG(1) << operation << " shortcut to " << chrome_exe.value() << " at "
           << chrome_link.value();
   if (!ShellUtil::UpdateChromeShortcut(browser_dist, chrome_exe.value(),
           chrome_link.value(), string16(), product_desc, chrome_exe.value(),
           browser_dist->GetIconIndex(), options)) {
     LOG(WARNING) << operation << " shortcut at " << chrome_link.value()
                  << " failed.";
   } else if (create_always &&
              base::win::GetVersion() >= base::win::VERSION_WIN7) {
     // If the Start Menu shortcut was successfully created and |create_always|,
     // proceed to pin the Start Menu shortcut to the taskbar on Win7+.
     VLOG(1) << "Pinning new shortcut at " << chrome_link.value()
             << " to taskbar";
     if (!file_util::TaskbarPinShortcutLink(chrome_link.value().c_str())) {
       LOG(ERROR) << "Failed to pin shortcut to taskbar: "
                  << chrome_link.value();
     }
   }
 
+  if (create_always && installer_state.system_install())
+    ForceCreateUserLevelStartMenuShortcut(installer_state, product);
+
   // Create/update uninstall link if we are not an MSI install. MSI
   // installations are, for the time being, managed only through the
   // Add/Remove Programs dialog.
   // TODO(robertshield): We could add a shortcut to msiexec /X {GUID} here.
   if (!installer_state.is_msi()) {
     // Uninstall Chrome link
     FilePath uninstall_link(start_menu_folder_path.Append(
         browser_dist->GetUninstallLinkName() + L".lnk"));
 
     CommandLine arguments(CommandLine::NO_PROGRAM);
     AppendUninstallCommandLineFlags(installer_state, product, &arguments);
     VLOG(1) << operation << " uninstall link at " << uninstall_link.value();
     if (!file_util::CreateOrUpdateShortcutLink(setup_exe.value().c_str(),
             uninstall_link.value().c_str(), NULL,
             arguments.GetCommandLineString().c_str(), NULL,
             setup_exe.value().c_str(), 0, NULL,
             create_always ? file_util::SHORTCUT_CREATE_ALWAYS :
                             file_util::SHORTCUT_NO_OPTIONS)) {
       LOG(WARNING) << operation << " uninstall link at "
                    << uninstall_link.value() << " failed.";
     }
   }
 }
 
+// TODO(gab): This is a hack that is temporarily required for the Start Menu
+// (now Start Screen) shortcut to show up on Win8. This will be removed when I'm
+// done refactoring ShellUtil as part of http://goo.gl/Az889.
+void ForceCreateUserLevelStartMenuShortcut(
+    const InstallerState& installer_state,
+    const Product& product) {
+  BrowserDistribution* browser_dist = product.distribution();

[grt (UTC plus 2), 2012/09/02 14:18:19]

to protect against someone accidentally calling this in the future for
user-level installs, how about adding:
  if (!installer_state.system_install()) {
    NOTREACHED();
    return;
  }

[gab, 2012/09/02 16:15:12]

Done.

+  const string16 product_name(browser_dist->GetAppShortCutName());
+  const string16 product_desc(browser_dist->GetAppDescription());
+  const FilePath chrome_exe(
+      installer_state.target_path().Append(installer::kChromeExe));
+
+  FilePath user_start_menu;
+  if (!PathService::Get(base::DIR_START_MENU, &user_start_menu)) {
+    LOG(DFATAL) << "Failed to get user-level start menu path.";
+    return;
+  }
+  user_start_menu = user_start_menu.Append(product_name);
+  // Make sure the directory exists (no need to handle the return value here
+  // as we still want to try to create the shortcut; if the directory is truly

[grt (UTC plus 2), 2012/09/02 14:18:19]

i find the "...as we still want to try..." part misleading since it implies that
creating the shortcut might still work.  there's no point in trying to create
the shortcut if the directory couldn't be created.  if you prefer to keep the
logic (which is fine with me), please make this comment more like:

// Ignore failures here since a failure to create the shortcut will be handled
below.

you can make it even more explicit by wrapping the next line in
ignore_result(...)

[gab, 2012/09/02 16:15:12]

Ended up deciding to wrap it in the if below. What I originally meant by "we
still want to try" is that I guess it's possible the the CreateDirectory call
fails, but the directory exists already. I also didn't want to add an extra
return value to handle it... but adding it to the if seems like a good solution.

+  // not present the shortcut creation will fail anyways).
+  file_util::CreateDirectory(user_start_menu);
+
+  const FilePath chrome_link(
+      user_start_menu.Append(product_name + L".lnk"));
+
+  const uint32 options = (ShellUtil::SHORTCUT_CREATE_ALWAYS |
+                          ShellUtil::SHORTCUT_DUAL_MODE);
+
+  VLOG(1) << "Creating shortcut to " << chrome_exe.value() << " at "
+          << chrome_link.value();
+  if (!ShellUtil::UpdateChromeShortcut(browser_dist, chrome_exe.value(),
+          chrome_link.value(), string16(), product_desc, chrome_exe.value(),
+          browser_dist->GetIconIndex(), options)) {
+    LOG(ERROR) << "Creating shortcut at " << chrome_link.value() << " failed.";
+  }
+}
+
 void CreateOrUpdateDesktopAndQuickLaunchShortcuts(
     const InstallerState& installer_state,
     const Product& product,
     uint32 options) {
   // TODO(tommi): Change this function to use WorkItemList.
   DCHECK(product.is_chrome());
 
   // Information used for all shortcut types
   BrowserDistribution* browser_dist = product.distribution();
   const string16 product_name(browser_dist->GetAppShortCutName());
@@ skipping 194 matching lines @@
     installer_state.RemoveOldVersionDirectories(
         new_version,
         existing_version.get(),
         install_temp_path);
   }
 
   return result;
 }
 
 }  // namespace installer