Install a user-level Start Menu shortcut for every user on system-installs through Active Setup

chrome/installer/setup/setup_main.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include <windows.h>
 #include <msi.h>
 #include <shellapi.h>
 #include <shlobj.h>
 
 #include "base/at_exit.h"
@@ skipping 1015 matching lines @@
 }
 
 // This method processes any command line options that make setup.exe do
 // various tasks other than installation (renaming chrome.exe, showing eula
 // among others). This function returns true if any such command line option
 // has been found and processed (so setup.exe should exit at that point).
 bool HandleNonInstallCmdLineOptions(const InstallationState& original_state,
                                     const CommandLine& cmd_line,
                                     InstallerState* installer_state,
                                     int* exit_code) {
+  // TODO(gab): Add a local |status| variable which each block below sets;
+  // only determine the |exit_code| from |status| at the end (this will allow
+  // this method to validate that
+  // (!handled || status != installer::UNKNOWN_STATUS)).
   bool handled = true;
   // TODO(tommi): Split these checks up into functions and use a data driven
   // map of switch->function.
   if (cmd_line.HasSwitch(installer::switches::kUpdateSetupExe)) {
     installer::InstallStatus status = installer::SETUP_PATCH_FAILED;
     // If --update-setup-exe command line option is given, we apply the given
     // patch to current exe, and store the resulting binary in the path
     // specified by --new-setup-exe. But we need to first unpack the file
     // given in --update-setup-exe.
     ScopedTempDir temp_path;
@@ skipping 37 matching lines @@
     // then the dialog is shown and regardless of the outcome setup exits here.
     string16 inner_frame =
         cmd_line.GetSwitchValueNative(installer::switches::kShowEula);
     *exit_code = ShowEULADialog(inner_frame);
     if (installer::EULA_REJECTED != *exit_code) {
       GoogleUpdateSettings::SetEULAConsent(
           original_state, BrowserDistribution::GetDistribution(), true);
     }
   } else if (cmd_line.HasSwitch(
       installer::switches::kConfigureUserSettings)) {
-    DCHECK(installer_state->system_install());
+    // NOTE: Should the work done here, on kConfigureUserSettings, change:
+    // kActiveSetupVersion in install_worker.cc needs to be increased for Active
+    // Setup to invoke this again for all users of this install.
     const Product* chrome_install =
         installer_state->FindProduct(BrowserDistribution::CHROME_BROWSER);
-    DCHECK(chrome_install);
-    // TODO(gab): Implement the new shortcut functionality here.
-    LOG(ERROR) << "--configure-user-settings is not implemented.";
+
+    // Create per-user Start Menu shortcuts.
+    // TODO(gab): This should really be more involved, but for now creating
+    // the shortcut and leaving it non-updated in later updates is fine.
+    // This is all coming in an upcoming refactoring of the shortcuts, but for
+    // now this will simply create the user-level shortcut once on the first
+    // (and only) invocation of Active Setup for Chrome for this user.
+    installer::InstallStatus status = installer::INVALID_STATE_FOR_OPTION;
+    if (chrome_install && installer_state->system_install()) {
+      ForceCreateUserLevelStartMenuShortcut(*installer_state, *chrome_install);
+      status = installer::INSTALL_REPAIRED;
+    } else {
+      LOG(DFATAL) << "chrome_install:" << chrome_install
+                  << ", system_install:" << installer_state->system_install();
+    }
+    *exit_code = InstallUtil::GetInstallReturnCode(status);
   } else if (cmd_line.HasSwitch(
       installer::switches::kRegisterChromeBrowser)) {
     installer::InstallStatus status = installer::UNKNOWN_STATUS;
     const Product* chrome_install =
         installer_state->FindProduct(BrowserDistribution::CHROME_BROWSER);
     if (chrome_install) {
       // If --register-chrome-browser option is specified, register all
       // Chrome protocol/file associations, as well as register it as a valid
       // browser for Start Menu->Internet shortcut. This switch will also
       // register Chrome as a valid handler for a set of URL protocols that
@@ skipping 57 matching lines @@
         installer_state->FindProduct(BrowserDistribution::CHROME_BROWSER);
     DCHECK(chrome_install);
     if (chrome_install) {
       installer::DeleteChromeRegistrationKeys(chrome_install->distribution(),
           HKEY_LOCAL_MACHINE, suffix, installer_state->target_path(), &tmp);
     }
     *exit_code = tmp;
   } else if (cmd_line.HasSwitch(installer::switches::kOnOsUpgrade)) {
     const Product* chrome_install =
         installer_state->FindProduct(BrowserDistribution::CHROME_BROWSER);
+    installer::InstallStatus status = installer::INVALID_STATE_FOR_OPTION;
     if (chrome_install) {
       installer::HandleOsUpgradeForBrowser(*installer_state,
                                            *chrome_install,
                                            cmd_line.GetProgram());
+      status = installer::INSTALL_REPAIRED;
+    } else {
+      LOG(DFATAL) << "Chrome product not found.";
     }
-    *exit_code = InstallUtil::GetInstallReturnCode(installer::INSTALL_REPAIRED);
+    *exit_code = InstallUtil::GetInstallReturnCode(status);
   } else if (cmd_line.HasSwitch(installer::switches::kInactiveUserToast)) {
     // Launch the inactive user toast experiment.
     int flavor = -1;
     base::StringToInt(cmd_line.GetSwitchValueNative(
         installer::switches::kInactiveUserToast), &flavor);
     std::string experiment_group =
         cmd_line.GetSwitchValueASCII(installer::switches::kExperimentGroup);
     DCHECK_NE(-1, flavor);
     if (flavor == -1) {
       *exit_code = installer::UNKNOWN_STATUS;
@@ skipping 316 matching lines @@
   if (!(installer_state.is_msi() && is_uninstall))
     // Note that we allow the status installer::UNINSTALL_REQUIRES_REBOOT
     // to pass through, since this is only returned on uninstall which is
     // never invoked directly by Google Update.
     return_code = InstallUtil::GetInstallReturnCode(install_status);
 
   VLOG(1) << "Installation complete, returning: " << return_code;
 
   return return_code;
 }