Install a user-level Start Menu shortcut for every user on system-installs through Active Setup

chrome/installer/setup/uninstall.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 //
 // This file defines the methods useful for uninstalling Chrome.
 
 #include "chrome/installer/setup/uninstall.h"
 
 #include <windows.h>
 
@@ skipping 280 matching lines @@
     FilePath shortcut_link(shortcut_path.Append(product_name + L".lnk"));
 
     VLOG(1) << "Unpinning shortcut at " << shortcut_link.value()
             << " from taskbar";
     // Ignore return value: keep uninstalling if the unpin fails.
     file_util::TaskbarUnpinShortcutLink(shortcut_link.value().c_str());
 
     VLOG(1) << "Deleting shortcut " << shortcut_path.value();
     if (!file_util::Delete(shortcut_path, true))
       LOG(ERROR) << "Failed to delete folder: " << shortcut_path.value();
+
+    // Also delete the per-user Start Menu shortcut possibly created by the
+    // Active Setup flow.
+    // TODO (gab): This is ugly, but I have a much cleaner solution to all of
+    // this in my upcoming refactoring.
+    if (installer_state.system_install()) {
+      PathService::Get(base::DIR_START_MENU, &shortcut_path);

[grt (UTC plus 2), 2012/09/01 03:20:28]

y u no handle return code?

[gab, 2012/09/01 22:28:40]

same comment as in other files, staying close to behavior temporarily copied
from above, but I agree that here it doesn't hurt to handle it.

Done.

[grt (UTC plus 2), 2012/09/02 14:18:19]

It's actively harmful to not handle it.  |shortcut_path| retains its previous
value if PathService returns false.  The code below adds to that and then does a
recursive Delete.  This happens as SYSTEM.  We must never call Delete(foo, true)
as SYSTEM unless we're certain what |foo| is.

+      shortcut_path = shortcut_path.Append(product_name);
+      VLOG(1) << "Deleting shortcut " << shortcut_path.value();
+      if (!file_util::Delete(shortcut_path, true))
+        LOG(ERROR) << "Failed to delete folder: " << shortcut_path.value();
+    }
   }
 }
 
 bool ScheduleParentAndGrandparentForDeletion(const FilePath& path) {
   FilePath parent_dir = path.DirName();
   bool ret = ScheduleFileSystemEntityForDeletion(parent_dir.value().c_str());
   if (!ret) {
     LOG(ERROR) << "Failed to schedule parent dir for deletion: "
                << parent_dir.value();
   } else {
@@ skipping 747 matching lines @@
     // !|remove_all| for now).
     if (installer_state.system_install() ||
         (remove_all &&
          ShellUtil::QuickIsChromeRegisteredInHKLM(
              browser_dist, chrome_exe, suffix))) {
       DeleteChromeRegistrationKeys(browser_dist, HKEY_LOCAL_MACHINE, suffix,
                                    installer_state.target_path(), &ret);
     }
 
     ProcessDelegateExecuteWorkItems(installer_state, product);
-
-// TODO(gab): This is only disabled for M22 as the shortcut CL using Active
-// Setup will not make it in M22.
-#if 0
     UninstallActiveSetupEntries(installer_state, product);
-#endif
   }
 
   if (product.is_chrome_frame()) {
     ProcessChromeFrameWorkItems(original_state, installer_state, setup_path,
                                 product);
   }
 
   if (installer_state.is_multi_install())
     ProcessGoogleUpdateItems(original_state, installer_state, product);
 
@@ skipping 96 matching lines @@
 
   // Try and delete the preserved local state once the post-install
   // operations are complete.
   if (!backup_state_file.empty())
     file_util::Delete(backup_state_file, false);
 
   return ret;
 }
 
 }  // namespace installer