Install a user-level Start Menu shortcut for every user on system-installs through Active Setup

base/file_util_win.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "base/file_util.h"
 
 #include <windows.h>
 #include <propvarutil.h>
 #include <psapi.h>
 #include <shellapi.h>
@@ skipping 428 matching lines @@
     if (app_id && !base::win::SetAppIdForPropertyStore(property_store, app_id))
       return false;
     if (is_dual_mode &&
         !base::win::SetDualModeForPropertyStore(property_store)) {
       return false;
     }
   }
 
   HRESULT result = i_persist_file->Save(destination, TRUE);
 
-  // If we successfully updated the icon, notify the shell that we have done so.
-  if (!create && SUCCEEDED(result)) {
-    // Release the interfaces in case the SHChangeNotify call below depends on
-    // the operations above being fully completed.
-    i_persist_file.Release();
-    i_shell_link.Release();
+  // Release the interfaces in case the SHChangeNotify call below depends on
+  // the operations above being fully completed.
+  i_persist_file.Release();
+  i_shell_link.Release();
 
-    SHChangeNotify(SHCNE_ASSOCCHANGED, SHCNF_IDLIST, NULL, NULL);
+  // If we successfully created/updated the icon, notify the shell that we have
+  // done so.
+  const bool succeeded = SUCCEEDED(result);
+  if (succeeded) {
+    if (create)
+      SHChangeNotify(SHCNE_CREATE, SHCNF_PATH, destination, NULL);
+    else

[grt (UTC plus 2), 2012/09/01 03:20:28]

add braces here and to the if side unless you remove the comment below

[gab, 2012/09/01 22:28:40]

Done.

+      // TODO(gab): Only use SHCNE_ASSOCCHANGED when the icon changed.

[grt (UTC plus 2), 2012/09/01 03:20:28]

is it even possible to put icon change detection logic down here?  i don't think
it is, in which case i don't think this TODO belongs.

[gab, 2012/09/01 22:28:40]

My goal is to modify this function to check (for updates not creates) if the
current state of the property it's about to update is the same as the current
one (and if so don't update it). We would only need to notify the shell in the
end if we actually did update something (we can special case the icon in the
detection too since that requires the nuclear SHCNE_ASSOCCHANGED bit).

This new notification mechanism will be particularly useful as we will install
the shortcut per-user through Active Setup as the only way to update shortcuts
post Chrome update will be at Active Setup (but that requires another login
which could arguably happen much much after the update) or at browser launch
(but we don't want a full desktop flash at every launch; hence the need to have
a more confined shell notification mechanism when updating shortcuts).

[grt (UTC plus 2), 2012/09/02 14:18:19]

The last time the icon changed, there was nothing visible to this function to
indicate such (same file, same resource id).  Let's discuss it in person with
Robert, who wrestled with this the last time around.

[grt (UTC plus 2), 2012/09/04 18:44:35]

As discussed, it isn't practical to detect the icon has changed, so please
remove.

[gab, 2012/09/04 18:51:07]

Done.

+      // Otherwise a simple SHCNE_UPDATEITEM should be sufficient.
+      SHChangeNotify(SHCNE_ASSOCCHANGED, SHCNF_IDLIST, NULL, NULL);
   }
 
-  return SUCCEEDED(result);
+  return succeeded;
 }
 
 bool TaskbarPinShortcutLink(const wchar_t* shortcut) {
   base::ThreadRestrictions::AssertIOAllowed();
 
   // "Pin to taskbar" is only supported after Win7.
   if (base::win::GetVersion() < base::win::VERSION_WIN7)
     return false;
 
   int result = reinterpret_cast<int>(ShellExecute(NULL, L"taskbarpin", shortcut,
@@ skipping 652 matching lines @@
   HANDLE cp = GetCurrentProcess();
   if (::GetMappedFileNameW(cp, file_view, mapped_file_path, kMaxPathLength)) {
     *nt_path = FilePath(mapped_file_path);
     success = true;
   }
   ::UnmapViewOfFile(file_view);
   return success;
 }
 
 }  // namespace file_util