Issue 10889026: Add hardfp flag to the Makefile.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10889026: Add hardfp flag to the Makefile. (Closed)

Created:
8 years, 3 months ago by Paweł Hajdan Jr.

Modified:
8 years, 3 months ago

Reviewers:
Jakob Kummerow

CC:
v8-dev

Base URL:
http://v8.googlecode.com/svn/branches/bleeding_edge/

Visibility:
Public.

More Reviews

Description

Add hardfp flag to the Makefile. This flag passes -Dv8_use_arm_eabi_hardfloat=true to gyp. This is needed for Linux distros that are experimenting with hardfp. BUG=none Committed: https://code.google.com/p/v8/source/detail?r=12412

Patch Set 1 #

Created: 8 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+4 lines, -0 lines)			Patch
	M	Makefile	View		1 chunk	+4 lines, -0 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Paweł Hajdan Jr.

For some more context see https://bugs.gentoo.org/show_bug.cgi?id=429298 I'm aware hardfp is somewhat experimental. This is totally ...

8 years, 3 months ago (2012-08-29 14:06:55 UTC) #1

Jakob Kummerow

8 years, 3 months ago (2012-08-29 14:17:37 UTC) #2

LGTM, I'll land it for you.

Whatever is good for Gentoo :-)

Expand Messages | Collapse Messages