lib/compiler/implementation/ssa/codegen.dart - Issue 10889022: Address comments from CL 10660026.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: lib/compiler/implementation/ssa/codegen.dart

Issue 10889022: Address comments from CL 10660026. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Created 8 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: lib/compiler/implementation/ssa/codegen.dart

diff --git a/lib/compiler/implementation/ssa/codegen.dart b/lib/compiler/implementation/ssa/codegen.dart

index d6e8284a610a95fe8e771bf0203450bb8f741d12..63f0684f79bf10098d9e36e70f11d68c9d83ba1a 100644

--- a/lib/compiler/implementation/ssa/codegen.dart

+++ b/lib/compiler/implementation/ssa/codegen.dart

@@ -1648,7 +1648,7 @@ class SsaCodeGenerator implements HVisitor, HBlockInformationVisitor {

visitForeign(HForeign node) {

String code = node.code.slowToString();

List<HInstruction> inputs = node.inputs;

- if (node.isStatement(types)) {

+ if (node.isJsStatement(types)) {

if (!inputs.isEmpty()) {

compiler.internalError("foreign statement with inputs: $code",

instruction: node);

« no previous file with comments | « no previous file | lib/compiler/implementation/ssa/codegen_helpers.dart » ('j') | no next file with comments »