Reset word iterators when changing the spellchecker language.

Reset word iterators when changing the spellchecker language.
My r101462 <http://crrev.com/101462>; caused an inconsistency between a spellchecker dictionary and a word iterator that it does not reset a word iterator when changing a spelchecker dictionary. Due to this inconsistency, our word iterator filters out Russian (Hebrew, Hindi, and Greek) characters when chaning from English to Russian (Hebrew, Hindi, and Greek), and vice versa. This change resets word iterators to fix this inconsistency.

BUG=142828
TEST=SpellCheckTest.MisspelledWords
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=153852

[Hironori Bono, 2012-08-28 06:03:06]

Morita-san,

Many thanks for your cooperation to Chrome spellchecker in advance. Would it be
possible to review another regression fix?

Regards,

Hironori Bono

[Hajime Morrita, 2012-08-28 07:00:34]

Thanks for fixing this. LGTM with a small nitpick.

http://codereview.chromium.org/10889002/diff/1/chrome/renderer/spellchecker/s...
File chrome/renderer/spellchecker/spellcheck.cc (right):

http://codereview.chromium.org/10889002/diff/1/chrome/renderer/spellchecker/s...
chrome/renderer/spellchecker/spellcheck.cc:133: contraction_iterator_.Close();
Nit* It's confusing to call Close() during Init().
It would be nice to have some better alias like Reset().

[Hironori Bono, 2012-08-29 08:41:45]

Morita-san,

Thanks for your review and comment. I have updated my change and landed the
updated one.

Regards,

Hironori Bono

http://codereview.chromium.org/10889002/diff/1/chrome/renderer/spellchecker/s...
File chrome/renderer/spellchecker/spellcheck.cc (right):

http://codereview.chromium.org/10889002/diff/1/chrome/renderer/spellchecker/s...
chrome/renderer/spellchecker/spellcheck.cc:133: contraction_iterator_.Close();
On 2012/08/28 07:00:34, morrita1 wrote:
> Nit* It's confusing to call Close() during Init().
> It would be nice to have some better alias like Reset().

Done. I have renamed Close() to Reset().