Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(561)

Unified Diff: lib/compiler/implementation/ssa/ssa.dart

Issue 10888003: Change how runtime type information is being set in the backend. (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 8 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « lib/compiler/implementation/ssa/nodes.dart ('k') | tests/co19/co19-dart2js.status » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: lib/compiler/implementation/ssa/ssa.dart
===================================================================
--- lib/compiler/implementation/ssa/ssa.dart (revision 11430)
+++ lib/compiler/implementation/ssa/ssa.dart (working copy)
@@ -31,29 +31,10 @@
#source('value_set.dart');
class RuntimeTypeInformation {
- String asJsString(InterfaceType type) {
- ClassElement element = type.element;
- StringBuffer buffer = new StringBuffer();
- Link<Type> arguments = type.arguments;
- Link<Type> typeVariables = element.typeVariables;
- while (!typeVariables.isEmpty()) {
- TypeVariableType typeVariable = typeVariables.head;
- // TODO(johnniwinther): Retrieve the type name properly and not through
- // [toString]. Note: Two cases below [typeVariable] and [arguments.head].
- buffer.add("${typeVariable}: '${arguments.head}'");
- typeVariables = typeVariables.tail;
- if (!typeVariables.isEmpty()) {
- buffer.add(', ');
- }
- }
- return "{$buffer}";
- }
-
bool hasTypeArguments(Type type) {
if (type is InterfaceType) {
InterfaceType interfaceType = type;
- return (!interfaceType.arguments.isEmpty() &&
- interfaceType.arguments.tail.isEmpty());
+ return !interfaceType.arguments.isEmpty();
}
return false;
}
« no previous file with comments | « lib/compiler/implementation/ssa/nodes.dart ('k') | tests/co19/co19-dart2js.status » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698