Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(271)

Side by Side Diff: tests/push-from-logs.sh

Issue 10887035: options.from_logs is not used anywhere since it's the default. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/tools/depot_tools
Patch Set: Created 8 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « git_cl.py ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 #!/bin/bash 1 #!/bin/bash
2 2
3 # Copyright (c) 2012 The Chromium Authors. All rights reserved. 3 # Copyright (c) 2012 The Chromium Authors. All rights reserved.
4 # Use of this source code is governed by a BSD-style license that can be 4 # Use of this source code is governed by a BSD-style license that can be
5 # found in the LICENSE file. 5 # found in the LICENSE file.
6 6
7 set -e 7 set -e
8 8
9 . ./test-lib.sh 9 . ./test-lib.sh
10 10
(...skipping 13 matching lines...) Expand all
24 "$GIT_CL upload 2>&1 | grep -q 'You must configure'" 24 "$GIT_CL upload 2>&1 | grep -q 'You must configure'"
25 25
26 git config rietveld.server localhost:8080 26 git config rietveld.server localhost:8080
27 27
28 test_expect_success "git-cl status has no issue" \ 28 test_expect_success "git-cl status has no issue" \
29 "$GIT_CL status | grep -q 'no issue'" 29 "$GIT_CL status | grep -q 'no issue'"
30 30
31 # Prevent the editor from coming up when you upload. 31 # Prevent the editor from coming up when you upload.
32 export EDITOR=$(which true) 32 export EDITOR=$(which true)
33 test_expect_success "upload succeeds (needs a server running on localhost)" \ 33 test_expect_success "upload succeeds (needs a server running on localhost)" \
34 "$GIT_CL upload -m test --desc_from_logs master | \ 34 "$GIT_CL upload -m test master | \
35 grep -q 'Issue created'" 35 grep -q 'Issue created'"
36 36
37 test_expect_success "git-cl status now knows the issue" \ 37 test_expect_success "git-cl status now knows the issue" \
38 "$GIT_CL status | grep -q 'Issue number'" 38 "$GIT_CL status | grep -q 'Issue number'"
39 39
40 # Check to see if the description contains the local commit messages. 40 # Check to see if the description contains the local commit messages.
41 # Should contain 'branch work' x 2. 41 # Should contain 'branch work' x 2.
42 test_expect_success "git-cl status has the right description for the log" \ 42 test_expect_success "git-cl status has the right description for the log" \
43 "$GIT_CL status --field desc | [ $( egrep -q '^branch work$' -c ) -eq 2 ] 43 "$GIT_CL status --field desc | [ $( egrep -q '^branch work$' -c ) -eq 2 ]
44 44
(...skipping 17 matching lines...) Expand all
62 test_expect_success "upstream repo has our commit" \ 62 test_expect_success "upstream repo has our commit" \
63 "git log master 2>/dev/null | [ $( egrep -q '^branch work$' -c ) -eq 2 ] 63 "git log master 2>/dev/null | [ $( egrep -q '^branch work$' -c ) -eq 2 ]
64 ) 64 )
65 SUCCESS=$? 65 SUCCESS=$?
66 66
67 cleanup 67 cleanup
68 68
69 if [ $SUCCESS == 0 ]; then 69 if [ $SUCCESS == 0 ]; then
70 echo PASS 70 echo PASS
71 fi 71 fi
OLDNEW
« no previous file with comments | « git_cl.py ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698