(GTK only) Replace checkboxes with menus and add support for managed settings.

(GTK only) Replace checkboxes with menus and add support for managed settings.


BUG=140450
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=154423

[markusheintz_, 2012-08-29 15:45:39]

Please review this CL. Thanks a lot.

@Elliot: Please review the GTK changes
@Ban: Please LGTM adding new files.

FYI: I will use the same MenuModel
(chrome/browser/ui/website_settings/permission_menu_model.h) code for the views
impl. I actually extracted the code from there
(chrome/browser/ui/view/website_settings/permission_selector_views*).

[Ben Goodger (Google), 2012-08-29 15:52:29]

https://chromiumcodereview.appspot.com/10887027/diff/2001/chrome/browser/ui/w...
File chrome/browser/ui/website_settings/permission_menu_model.h (right):

https://chromiumcodereview.appspot.com/10887027/diff/2001/chrome/browser/ui/w...
chrome/browser/ui/website_settings/permission_menu_model.h:15: class
PermissionMenuDelegate {
Delegate or Observer?

[markusheintz_, 2012-08-29 16:15:22]

https://chromiumcodereview.appspot.com/10887027/diff/2001/chrome/browser/ui/w...
File chrome/browser/ui/website_settings/permission_menu_model.h (right):

https://chromiumcodereview.appspot.com/10887027/diff/2001/chrome/browser/ui/w...
chrome/browser/ui/website_settings/permission_menu_model.h:15: class
PermissionMenuDelegate {
On 2012/08/29 15:52:29, Ben Goodger (Google) wrote:
> Delegate or Observer?

Done.

[Elliot Glaysher, 2012-08-29 16:55:50]

gtk lgtm

[Ben Goodger (Google), 2012-08-29 17:28:05]

lgtm2

it'd probably be a delegate if you intend there to be non-observer sounding
methods on there at some point.

a delegate helps the class perform a task it can't complete by itself.

an observer is notified of state changes in the class, but isn't essential for
the class' function.

[markusheintz_, 2012-08-29 19:51:38]

On 2012/08/29 17:28:05, Ben Goodger (Google) wrote:
> lgtm2
> 
> it'd probably be a delegate if you intend there to be non-observer sounding
> methods on there at some point.
> 
> a delegate helps the class perform a task it can't complete by itself.
> 
> an observer is notified of state changes in the class, but isn't essential for
> the class' function.

Thanks a lot for the explanation.

Patchset 4 addresses the naming issue.

Thinking a bit more about this I guess

Patchset 5 is what I actually want.

[Ben Goodger (Google), 2012-08-30 21:16:47]

lgtm

[commit-bot: I haz the power, 2012-08-30 21:32:40]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/markusheintz@chromium.org/10887027/6002

[commit-bot: I haz the power, 2012-08-30 22:31:18]

Try job failure for 10887027-6002 (retry) on linux_clang for step "compile"
(clobber build).
It's a second try, previously, step "compile" failed.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_clan...

[commit-bot: I haz the power, 2012-08-31 10:09:35]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/markusheintz@chromium.org/10887027/25001