Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(34)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 10887021: Remove GetLastActive from NetworkProfileBubble. (Closed)

Created:
8 years, 3 months ago by robertshield
Modified:
8 years, 3 months ago
CC:
chromium-reviews
Visibility:
Public.

Description

Remove GetLastActive from NetworkProfileBubble. BUG=129187 TEST=NONE Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=154280

Patch Set 1 #

Total comments: 1

Patch Set 2 : Adding TODO as per MAD. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -2 lines) Patch
M chrome/browser/ui/network_profile_bubble.cc View 1 2 chunks +9 lines, -2 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
robertshield
8 years, 3 months ago (2012-08-29 14:45:47 UTC) #1
Ben Goodger (Google)
lgtm
8 years, 3 months ago (2012-08-29 15:51:39 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/robertshield@chromium.org/10887021/1
8 years, 3 months ago (2012-08-29 17:44:03 UTC) #3
commit-bot: I haz the power
Try job failure for 10887021-1 (retry) (retry) (retry) on win_rel for step "browser_tests". It's a ...
8 years, 3 months ago (2012-08-29 23:22:02 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/robertshield@chromium.org/10887021/1
8 years, 3 months ago (2012-08-30 11:10:31 UTC) #5
commit-bot: I haz the power
Try job failure for 10887021-1 (retry) on linux_rel for step "interactive_ui_tests". It's a second try, ...
8 years, 3 months ago (2012-08-30 13:02:45 UTC) #6
MAD
Just one small comment/question/request for a potential TODO to add... Thanks! BYE MAD Ho... and... ...
8 years, 3 months ago (2012-08-30 13:45:22 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/robertshield@chromium.org/10887021/20002
8 years, 3 months ago (2012-08-30 18:43:03 UTC) #8
commit-bot: I haz the power
8 years, 3 months ago (2012-08-30 22:02:00 UTC) #9 
Change committed as 154280

Powered by Google App Engine
This is Rietveld 408576698