Issue 10887018: Extensions Doc Server 2: Fixes for beta branch

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10887018: Extensions Doc Server 2: Fixes for beta branch (Closed)

Created:
8 years, 3 months ago by Aaron Boodman

Modified:
8 years, 3 months ago

Reviewers:
not at google - send to devlin

CC:
chromium-reviews, Aaron Boodman, mihaip-chromium-reviews_chromium.org, cduvall

Base URL:
svn://svn.chromium.org/chrome/branches/1229_12/src/

Visibility:
Public.

More Reviews

Description

Extensions Doc Server 2: Fixes for beta branch Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=153853

Patch Set 1 #

Patch Set 2 : #

Total comments: 1

Created: 8 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+4 lines, -4 lines)			Patch
M	chrome/common/extensions/docs/server2/templates/intros/events.html	View		2 chunks	+3 lines, -2 lines	1 comment	Download
M	chrome/common/extensions/docs/server2/templates/public/apps/app_window.html	View		1 chunk	+1 line, -1 line	0 comments	Download
D	chrome/common/extensions/docs/server2/templates/public/apps/experimental_serial.html	View	1	1 chunk	+0 lines, -1 line	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

not at google - send to devlin

8 years, 3 months ago (2012-08-29 03:31:37 UTC) #2

lgtm

https://chromiumcodereview.appspot.com/10887018/diff/2001/chrome/common/exten...
File chrome/common/extensions/docs/server2/templates/intros/events.html (right):

https://chromiumcodereview.appspot.com/10887018/diff/2001/chrome/common/exten...
chrome/common/extensions/docs/server2/templates/intros/events.html:158: {{/}}
{{/is_apps}} for readability. it's also what is checked into trunk.

Expand Messages | Collapse Messages