Rename members and named constructors.

tests/compiler/dart2js/unparser_test.dart

 // Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 #import('dart:uri');
 #import('parser_helper.dart');
 #import('mock_compiler.dart');
 #import("../../../lib/compiler/compiler.dart");
 #import("../../../lib/compiler/implementation/leg.dart", prefix:'leg');
 #import("../../../lib/compiler/implementation/dart_backend/dart_backend.dart");
@@ skipping 13 matching lines @@
 const coreLib = @'''
 #library('corelib');
 class Object {}
 interface bool {}
 interface num {}
 interface int extends num {}
 interface double extends num {}
 interface String {}
 interface Function {}
 interface List {}
+interface Map {}
 interface Closure {}
 interface Dynamic {}
 interface Null {}
 assert() {}
 class Math {
   static double parseDouble(String s) => 1.0;
 }
 ''';
 
 const ioLib = @'''
@@ skipping 425 matching lines @@
   var src = '''
 main() {
   function localfoo() {}
   localfoo();
 }
 ''';
   MockCompiler compiler = new MockCompiler();
   compiler.parseScript(src);
   FunctionElement mainElement = compiler.mainApp.find(leg.Compiler.MAIN);
   compiler.processQueue(compiler.enqueuer.resolution, mainElement);
-  PlaceholderCollector collector = new PlaceholderCollector(compiler);
+  PlaceholderCollector collector =
+      new PlaceholderCollector(compiler, new Set<String>());
   collector.collect(mainElement,
       compiler.enqueuer.resolution.resolvedElements[mainElement]);
   FunctionExpression mainNode = mainElement.parseNode(compiler);
   FunctionExpression fooNode = mainNode.body.statements.nodes.head.function;
   LocalPlaceholder fooPlaceholder =
       collector.functionScopes[mainElement].localPlaceholders.iterator().next();
   Expect.isTrue(fooPlaceholder.nodes.contains(fooNode.name));
 }
 
 testDefaultClassNamePlaceholder() {
   var src = '''
 interface I default C{
   I();
 }
 
 class C {
   I() {}
 }
 
 main() {
   new I();
 }
 ''';
   MockCompiler compiler = new MockCompiler();
   compiler.parseScript(src);
   ClassElement interfaceElement = compiler.mainApp.find(buildSourceString('I'));
   interfaceElement.ensureResolved(compiler);
-  PlaceholderCollector collector = new PlaceholderCollector(compiler);
+  PlaceholderCollector collector =
+      new PlaceholderCollector(compiler, new Set<String>());
   collector.collect(interfaceElement,
       compiler.enqueuer.resolution.resolvedElements[interfaceElement]);
   ClassNode interfaceNode = interfaceElement.parseNode(compiler);
   Node defaultTypeNode = interfaceNode.defaultClause.typeName;
   ClassElement classElement = compiler.mainApp.find(buildSourceString('C'));
   // Check that 'C' in default clause of I gets into placeholders.
   Expect.isTrue(collector.elementNodes[classElement].contains(defaultTypeNode));
 }
 
 testFactoryRename() {
@@ skipping 219 matching lines @@
   arg = 6;
 }
 
 main() {
   new A().a;
   A.foo(8);
   fooglobal(8);
 }
 ''';
   var expectedResult =
-      'class A{var a;static B(b){b=5;}}'
+      'class A{var D;static B(b){b=5;}}'
       'C(a,[optionalarg=7]){a=6;}'
-      'main(){new A().a; A.B(8); C(8);}';
+      'main(){new A().D; A.B(8); C(8);}';
   testDart2Dart(src,
       (String result) { Expect.equals(expectedResult, result); }, minify: true);
 }
 
 testTypeVariablesInDifferentLibraries() {
 // This is a simplified version of what we have in
 // lib/compiler/implementation/util.
   var librarySrc = '''
 #library('mylib');
 #import('script.dart');
@@ skipping 36 matching lines @@
   foo("5");
 }
 ''';
   var expectedResult =
       ' foo( arg){}main(){var localvar; foo("5");}';
   testDart2Dart(src,
       (String result) { Expect.equals(expectedResult, result); },
       cutDeclarationTypes: true);
 }
 
 main() {

[Roman, 2012/08/29 08:40:09]

Please add one complicated test for member renames, something with classes that
have member fields and methods, with named constructors and getters/setters.

[Anton Muhin, 2012/08/29 09:43:46]

I thought about that, but eventually decided against as we have very good
coverage for this stuff by other suites: it hard to rename one member
incorrectly and get reasonably sized test pass.

On 2012/08/29 08:40:09, Roman wrote:

   testSignedConstants();
   testGenericTypes();
   testForLoop();
   testEmptyList();
   testClosure();
   testIndexedOperatorDecl();
   testNativeMethods();
   testPrefixIncrements();
   testConstModifier();
   testSimpleFileUnparse();
@@ skipping 22 matching lines @@
   testDoubleMains();
   testInterfaceDefaultAnotherLib();
   testStaticAccessIoLib();
   testLocalFunctionPlaceholder();
   testMinification();
   testClosureLocalsMinified();
   testParametersMinified();
   testTypeVariablesInDifferentLibraries();
   testDeclarationTypePlaceholders();
 }