Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(612)

Unified Diff: runtime/vm/il_printer.cc

Issue 10887009: Refactor branch instructions to enable further optimizations. (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 8 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « runtime/vm/flow_graph_optimizer.cc ('k') | runtime/vm/intermediate_language.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/il_printer.cc
===================================================================
--- runtime/vm/il_printer.cc (revision 11450)
+++ runtime/vm/il_printer.cc (working copy)
@@ -554,33 +554,16 @@
void BranchInstr::PrintTo(BufferFormatter* f) const {
- f->Print(" %s:%d ", DebugName(), deopt_id());
+ f->Print(" %s ", DebugName());
f->Print("if ");
- left()->PrintTo(f);
- f-> Print(" %s ", Token::Str(kind()));
- right()->PrintTo(f);
+ computation()->PrintTo(f);
f->Print(" goto (%d, %d)",
true_successor()->block_id(),
false_successor()->block_id());
- if (HasICData()) {
- PrintICData(f, *ic_data());
- }
}
-void StrictCompareAndBranchInstr::PrintTo(BufferFormatter* f) const {
- f->Print(" %s", DebugName());
- f->Print("if ");
- left()->PrintTo(f);
- f-> Print(" %s ", Token::Str(kind()));
- right()->PrintTo(f);
- f->Print(" goto (%d, %d)",
- true_successor()->block_id(),
- false_successor()->block_id());
-}
-
-
void ParallelMoveInstr::PrintTo(BufferFormatter* f) const {
f->Print(" %s ", DebugName());
for (intptr_t i = 0; i < moves_.length(); i++) {
@@ -828,27 +811,13 @@
void BranchInstr::PrintToVisualizer(BufferFormatter* f) const {
f->Print("_ %s ", DebugName());
f->Print("if ");
- left()->PrintTo(f);
- f-> Print(" %s ", Token::Str(kind()));
- right()->PrintTo(f);
+ computation()->PrintTo(f);
f->Print(" goto (B%d, B%d)",
true_successor()->block_id(),
false_successor()->block_id());
}
-void StrictCompareAndBranchInstr::PrintToVisualizer(BufferFormatter* f) const {
- f->Print("_ %s ", DebugName());
- f->Print("if ");
- left()->PrintTo(f);
- f-> Print(" %s ", Token::Str(kind()));
- right()->PrintTo(f);
- f->Print(" goto (B%d, B%d)",
- true_successor()->block_id(),
- false_successor()->block_id());
-}
-
-
void ParallelMoveInstr::PrintToVisualizer(BufferFormatter* f) const {
UNIMPLEMENTED();
}
« no previous file with comments | « runtime/vm/flow_graph_optimizer.cc ('k') | runtime/vm/intermediate_language.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698