Issue 10887006: Don't record browser window display UMA if first run dialog is shown

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10887006: Don't record browser window display UMA if first run dialog is shown (Closed)

Created:
8 years, 3 months ago by jeremy

Modified:
8 years, 3 months ago

Reviewers:
sky

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Don't record browser window display UMA if first run dialog is shown Missed this in http://codereview.chromium.org/10662046/ . Don't record the Startup.BrowserWindowDisplay UMA if the first run UI is displayed. This is the only other place I could find in the code that was displaying a custom dialog on startup on Win/Mac. The previous CL added this call to the ShowMessageBox() call so all other dialogs should be covered. BUG=None TEST=None Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=153770

Patch Set 1 #

Created: 8 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -0 lines)			Patch
	M	chrome/browser/first_run/first_run.cc	View		2 chunks	+2 lines, -0 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jeremy@chromium.org/10887006/1

8 years, 3 months ago (2012-08-28 18:22:08 UTC) #3

Change committed as 153770

Expand Messages | Collapse Messages