Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(152)

Issue 10886050: Add code to insure we are using the correct library. (Closed)

Created:
8 years, 3 months ago by Emmanuel Saint-loubert-Bié
Modified:
8 years, 3 months ago
Reviewers:
brettw, sky
CC:
chromium-reviews
Visibility:
Public.

Description

Add checks in the code so that we can guarantee that we are using the correct library as specified via common.gypi BUG=144296 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=154189

Patch Set 1 #

Patch Set 2 : fixed DEPS #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -1 line) Patch
M build/common.gypi View 2 chunks +4 lines, -0 lines 0 comments Download
M ui/gfx/codec/DEPS View 1 1 chunk +1 line, -0 lines 0 comments Download
M ui/gfx/codec/jpeg_codec.cc View 1 1 chunk +3 lines, -1 line 0 comments Download

Messages

Total messages: 6 (0 generated)
Emmanuel Saint-loubert-Bié
Hi Brett, This is the change we discussed, the only problem is that it breaks ...
8 years, 3 months ago (2012-08-29 22:22:40 UTC) #1
Emmanuel Saint-loubert-Bié
OK with fixed DEPS! -- E
8 years, 3 months ago (2012-08-30 00:01:43 UTC) #2
brettw
lgtm
8 years, 3 months ago (2012-08-30 05:35:20 UTC) #3
Emmanuel Saint-loubert-Bié
sky for OWNER please! Thanks, -- Emmanuel
8 years, 3 months ago (2012-08-30 15:33:13 UTC) #4
sky
LGTM
8 years, 3 months ago (2012-08-30 16:09:55 UTC) #5
commit-bot: I haz the power
8 years, 3 months ago (2012-08-30 16:14:36 UTC) #6

Powered by Google App Engine
This is Rietveld 408576698