Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(269)

Issue 10886022: Fix encrypted AAC in BMFF by adding subsample info. (Closed)

Created:
8 years, 3 months ago by strobe_
Modified:
8 years, 3 months ago
CC:
chromium-reviews, feature-media-reviews_chromium.org, ddorwin
Visibility:
Public.

Description

Fix encrypted AAC in BMFF by adding subsample info. AAC audio is sent to the Source Buffer in ADTS format, which requires adding a header to each media sample. Encrypted subsample information was not being adjusted to compensate for the extra clear bytes. TEST=Manual, pending audio decryption support in decoder BUG=132351 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=153854

Patch Set 1 #

Total comments: 2

Patch Set 2 : Use constant in ConvertEsdsToADTS #

Unified diffs Side-by-side diffs Delta from patch set Stats (+43 lines, -17 lines) Patch
M media/mp4/aac.h View 1 chunk +3 lines, -0 lines 0 comments Download
M media/mp4/aac.cc View 1 2 chunks +2 lines, -2 lines 0 comments Download
M media/mp4/mp4_stream_parser.h View 1 chunk +3 lines, -0 lines 0 comments Download
M media/mp4/mp4_stream_parser.cc View 2 chunks +35 lines, -15 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
strobe_
Small fix for encrypted audio. Tested on two platforms (GStreamer/ClearKey and [major SOC vendor]/PlayReady).
8 years, 3 months ago (2012-08-28 23:07:32 UTC) #1
acolwell GONE FROM CHROMIUM
LGTM % minor nit https://chromiumcodereview.appspot.com/10886022/diff/1/media/mp4/aac.h File media/mp4/aac.h (right): https://chromiumcodereview.appspot.com/10886022/diff/1/media/mp4/aac.h#newcode50 media/mp4/aac.h:50: static const size_t kADTSHeaderSize = ...
8 years, 3 months ago (2012-08-28 23:28:42 UTC) #2
strobe_
https://chromiumcodereview.appspot.com/10886022/diff/1/media/mp4/aac.h File media/mp4/aac.h (right): https://chromiumcodereview.appspot.com/10886022/diff/1/media/mp4/aac.h#newcode50 media/mp4/aac.h:50: static const size_t kADTSHeaderSize = 7; On 2012/08/28 23:28:42, ...
8 years, 3 months ago (2012-08-28 23:44:09 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/strobe@google.com/10886022/5001
8 years, 3 months ago (2012-08-28 23:45:17 UTC) #4
commit-bot: I haz the power
8 years, 3 months ago (2012-08-29 04:24:18 UTC) #5
Change committed as 153854

Powered by Google App Engine
This is Rietveld 408576698