Issue 10886012: Release stack trace data after firing Error.stack accessor.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10886012: Release stack trace data after firing Error.stack accessor. (Closed)

Created:
8 years, 3 months ago by Yang

Modified:
8 years, 3 months ago

Reviewers:
Vyacheslav Egorov (Google), Vyacheslav Egorov (Chromium)

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

Release stack trace data after firing Error.stack accessor. BUG=v8:2308 Committed: https://code.google.com/p/v8/source/detail?r=12403

Patch Set 1 #

Total comments: 2

Patch Set 2 : #

Created: 8 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+58 lines, -5 lines)			Patch
	M	src/messages.js	View		1 chunk	+5 lines, -5 lines	0 comments	Download
	M	test/cctest/test-heap.cc	View	1	1 chunk	+53 lines, -0 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Vyacheslav Egorov (Google)

8 years, 3 months ago (2012-08-28 16:43:43 UTC) #2

lgtm

http://codereview.chromium.org/10886012/diff/1/src/messages.js
File src/messages.js (right):

http://codereview.chromium.org/10886012/diff/1/src/messages.js#newcode770
src/messages.js:770: var getter_function = fun;
Is there any reason why you can't simply use fun without creating a separate
variable?

If there is one: please add a comment explaining that, otherwise: please use fun
[possibly renaming it into make_value, value_factory or something]

http://codereview.chromium.org/10886012/diff/1/test/cctest/test-heap.cc
File test/cctest/test-heap.cc (right):

http://codereview.chromium.org/10886012/diff/1/test/cctest/test-heap.cc#newco...
test/cctest/test-heap.cc:2238: delete resource;
thanks for writing a test!

Expand Messages | Collapse Messages