Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3266)

Unified Diff: chrome/common/extensions/PRESUBMIT_test.py

Issue 10885049: Extensions Docs Server: KILL BUILD.PY (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 8 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/common/extensions/PRESUBMIT_test.py
diff --git a/chrome/common/extensions/PRESUBMIT_test.py b/chrome/common/extensions/PRESUBMIT_test.py
index d20ab93081631ec287598f6f70d7103d3f96a363..6236eee7486d5abf3c706c9cfc81a2b5feb4d728 100755
--- a/chrome/common/extensions/PRESUBMIT_test.py
+++ b/chrome/common/extensions/PRESUBMIT_test.py
@@ -41,68 +41,6 @@ class TestPresubmit(unittest.TestCase):
def assertPathsEqual(self, path1, path2):
self.assertEqual(os.path.normpath(path1), os.path.normpath(path2))
- def testCheckDocsChanges_NoFiles(self):
- input_api = FakeInputApi(affected_files=[])
- self.assertEqual([], PRESUBMIT.CheckDocChanges(input_api, self.output_api))
-
- def testCheckDocsChanges_OnlyExcpetions(self):
- input_api = FakeInputApi(affected_files=[
- FakeAffectedFile(local_path='chrome/common/extensions/docs/README'),
- FakeAffectedFile(local_path='chrome/common/extensions/docs/OWNERS')])
- self.assertEqual([], PRESUBMIT.CheckDocChanges(input_api, self.output_api))
-
- def testCheckDocsChanges_NoGeneratedFiles(self):
- input_api = FakeInputApi(affected_files=[
- FakeAffectedFile(
- local_path='chrome/common/extensions/api/foo.json'),
- FakeAffectedFile(
- local_path='chrome/common/extensions/docs/examples/foo/b/bz.js'),
- FakeAffectedFile(
- local_path='chrome/common/extensions/docs/static/foo.html')])
- expected_warning = (
- 'This change modifies the extension docs but the generated docs '
- 'have not been updated properly. See %s for more info.\n'
- ' - Changes to %s not reflected in generated doc.\n'
- ' - Changes to sample %s have not been re-zipped.\n'
- ' - Docs out of sync with %s changes.\n'
- 'First build DumpRenderTree, then update the docs by running:\n %s'
- ' --page-name=<apiName>' %
- (os.path.normpath('chrome/common/extensions/docs/README.txt'),
- os.path.normpath('chrome/common/extensions/docs/static/foo.html'),
- os.path.normpath('chrome/common/extensions/docs/examples/foo/b/bz.js'),
- os.path.normpath('chrome/common/extensions/api/foo.json'),
- os.path.normpath('chrome/common/extensions/docs/build/build.py')))
- self.assertEqual([expected_warning],
- PRESUBMIT.CheckDocChanges(input_api, self.output_api))
-
- def testCheckDocsChanges_OnlyGeneratedDocs(self):
- input_api = FakeInputApi(affected_files=[
- FakeAffectedFile(
- local_path='chrome/common/extensions/docs/apps/foo.html'),
- FakeAffectedFile(
- local_path='chrome/common/extensions/docs/extensions/foo.html'),
- FakeAffectedFile(
- local_path='chrome/common/extensions/docs/apps/bar.html'),
- FakeAffectedFile(
- local_path='chrome/common/extensions/docs/extensions/baz.html')])
- expected_warning = (
- 'This change modifies the extension docs but the generated docs '
- 'have not been updated properly. See %s for more info.\n'
- ' - Changes to generated doc %s not reflected in non-generated files.\n'
- ' - Changes to generated doc %s not reflected in non-generated files.\n'
- ' - Changes to generated doc %s not reflected in non-generated files.\n'
- ' - Changes to generated doc %s not reflected in non-generated files.\n'
- 'First build DumpRenderTree, then update the docs by running:\n %s'
- ' --page-name=<apiName>' %
- (os.path.normpath('chrome/common/extensions/docs/README.txt'),
- os.path.normpath('chrome/common/extensions/docs/apps/bar.html'),
- os.path.normpath('chrome/common/extensions/docs/apps/foo.html'),
- os.path.normpath('chrome/common/extensions/docs/extensions/baz.html'),
- os.path.normpath('chrome/common/extensions/docs/extensions/foo.html'),
- os.path.normpath('chrome/common/extensions/docs/build/build.py')))
- self.assertEqual([expected_warning],
- PRESUBMIT.CheckDocChanges(input_api, self.output_api))
-
def testIsSkippedFile(self):
self.assertTrue(PRESUBMIT.IsSkippedFile(
os.path.normpath('chrome/common/extensions/docs/README.txt'),

Powered by Google App Engine
This is Rietveld 408576698