runtime/vm/intermediate_language.cc - Issue 10885039: Deoptimization can occur at Dart calls (includes native calls to C) but not at runtime calls. This …

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: runtime/vm/intermediate_language.cc

Issue 10885039: Deoptimization can occur at Dart calls (includes native calls to C) but not at runtime calls. This … (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Patch Set: Created 8 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: runtime/vm/intermediate_language.cc

===================================================================

--- runtime/vm/intermediate_language.cc (revision 11621)

+++ runtime/vm/intermediate_language.cc (working copy)

@@ -1321,11 +1321,11 @@

DartEntry::ArgumentsDescriptor(argument_count - 1,

argument_names());

__ LoadObject(temp_reg, arguments_descriptor);

- compiler->GenerateCall(token_pos(),

- &StubCode::CallClosureFunctionLabel(),

- PcDescriptors::kOther,

- locs());

+ compiler->GenerateDartCall(deopt_id(),

+ token_pos(),

+ &StubCode::CallClosureFunctionLabel(),

+ PcDescriptors::kOther,

+ locs());

__ Drop(argument_count);

}

@@ -1336,7 +1336,7 @@

void InstanceCallComp::EmitNativeCode(FlowGraphCompiler* compiler) {

- compiler->AddCurrentDescriptor(PcDescriptors::kDeopt,

+ compiler->AddCurrentDescriptor(PcDescriptors::kDeoptBefore,

deopt_id(),

token_pos());

compiler->GenerateInstanceCall(deopt_id(),

« no previous file with comments | « runtime/vm/intermediate_language.h ('k') | runtime/vm/intermediate_language_ia32.cc » ('j') | no next file with comments »