Deoptimization can occur at Dart calls (includes native calls to C) but not at runtime calls. This …

runtime/vm/object.cc

 // Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 #include "vm/object.h"
 
 #include "include/dart_api.h"
 #include "platform/assert.h"
 #include "vm/assembler.h"
 #include "vm/bigint_operations.h"
@@ skipping 3891 matching lines @@
 
 
 void Function::set_num_optional_parameters(intptr_t n) const {
   ASSERT(n >= 0);
   raw_ptr()->num_optional_parameters_ = n;
 }
 
 
 bool Function::is_optimizable() const {
   return OptimizableBit::decode(raw_ptr()->kind_tag_) &&
-         (script() != Script::null());
+         (script() != Script::null()) &&
+         !is_native();
 }
 
 
 void Function::set_is_optimizable(bool value) const {
   uword bits = raw_ptr()->kind_tag_;
   raw_ptr()->kind_tag_ = OptimizableBit::update(value, bits);
 }
 
 
 void Function::set_has_finally(bool value) const {
@@ skipping 2724 matching lines @@
     NoGCScope no_gc;
     result ^= raw;
     result.SetLength(num_descriptors);
   }
   return result.raw();
 }
 
 
 const char* PcDescriptors::KindAsStr(intptr_t index) const {
   switch (DescriptorKind(index)) {
-    case PcDescriptors::kDeopt:      return "deopt   ";
-    case PcDescriptors::kDeoptIndex: return "deopt-ix";
-    case PcDescriptors::kPatchCode:  return "patch   ";
-    case PcDescriptors::kIcCall:     return "ic-call ";
-    case PcDescriptors::kFuncCall:   return "fn-call ";
-    case PcDescriptors::kReturn:     return "return  ";
-    case PcDescriptors::kOther:      return "other   ";
+    case PcDescriptors::kDeoptBefore: return "deopt-before ";
+    case PcDescriptors::kDeoptAfter:  return "deopt-after  ";
+    case PcDescriptors::kDeoptIndex:  return "deopt-ix     ";
+    case PcDescriptors::kPatchCode:   return "patch        ";
+    case PcDescriptors::kIcCall:      return "ic-call      ";
+    case PcDescriptors::kFuncCall:    return "fn-call      ";
+    case PcDescriptors::kReturn:      return "return       ";
+    case PcDescriptors::kOther:       return "other        ";
   }
   UNREACHABLE();
   return "";
 }
 
 
 void PcDescriptors::PrintHeaderString() {
   // 4 bits per hex digit + 2 for "0x".
   const int addr_width = (kBitsPerWord / 4) + 2;
   // "*" in a printf format specifier tells it to read the field width from
@@ skipping 61 matching lines @@
       OS::Print("Not checking pc decriptors, length %d\n", Length());
     }
     return;
   }
   for (intptr_t i = 0; i < Length(); i++) {
     uword pc = PC(i);
     PcDescriptors::Kind kind = DescriptorKind(i);
     // 'deopt_id' is set for kDeopt and kIcCall and must be unique for one kind.
     intptr_t deopt_id = Isolate::kNoDeoptId;
     if (check_ids) {
-      if ((DescriptorKind(i) == PcDescriptors::kDeopt) ||
+      if ((DescriptorKind(i) == PcDescriptors::kDeoptBefore) ||
           (DescriptorKind(i) == PcDescriptors::kIcCall)) {
         deopt_id = DeoptId(i);
       }
     }
     for (intptr_t k = i + 1; k < Length(); k++) {
       if (kind == DescriptorKind(k)) {
         if (deopt_id != Isolate::kNoDeoptId) {
           ASSERT(DeoptId(k) != deopt_id);
         }
         ASSERT(pc != PC(k));
@@ skipping 526 matching lines @@
   for (intptr_t i = 0; i < descriptors.Length(); i++) {
     if (descriptors.PC(i) == pc) {
       token_pos = descriptors.TokenPos(i);
       break;
     }
   }
   return token_pos;
 }
 
 
-uword Code::GetDeoptPcAtDeoptId(intptr_t deopt_id) const {
+uword Code::GetPcForDeoptId(intptr_t deopt_id, PcDescriptors::Kind kind) const {
   const PcDescriptors& descriptors = PcDescriptors::Handle(pc_descriptors());
   for (intptr_t i = 0; i < descriptors.Length(); i++) {
     if ((descriptors.DeoptId(i) == deopt_id) &&
-        (descriptors.DescriptorKind(i) == PcDescriptors::kDeopt)) {
-      return descriptors.PC(i);
+        (descriptors.DescriptorKind(i) == kind)) {
+      uword pc = descriptors.PC(i);
+      ASSERT((EntryPoint() < pc) && (pc < (EntryPoint() + Size())));
+      return pc;
     }
   }
   return 0;
 }
 
 
+uword Code::GetDeoptBeforePcAtDeoptId(intptr_t deopt_id) const {
+  ASSERT(!is_optimized());
+  return GetPcForDeoptId(deopt_id, PcDescriptors::kDeoptBefore);
+}
+
+
+uword Code::GetDeoptAfterPcAtDeoptId(intptr_t deopt_id) const {
+  ASSERT(!is_optimized());
+  return GetPcForDeoptId(deopt_id, PcDescriptors::kDeoptAfter);
+}
+
+
 const char* Code::ToCString() const {
   const char* kFormat = "Code entry:0x%d";
   intptr_t len = OS::SNPrint(NULL, 0, kFormat, EntryPoint()) + 1;
   char* chars = Isolate::Current()->current_zone()->Alloc<char>(len);
   OS::SNPrint(chars, len, kFormat, EntryPoint());
   return chars;
 }
 
 
 uword Code::GetPatchCodePc() const {
@@ skipping 3869 matching lines @@
   }
   return result.raw();
 }
 
 
 const char* WeakProperty::ToCString() const {
   return "_WeakProperty";
 }
 
 }  // namespace dart