Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(792)

Issue 10885034: Disable flaky test on windows (Closed)

Created:
8 years, 3 months ago by eroman
Modified:
8 years, 3 months ago
Reviewers:
sreeram
CC:
chromium-reviews, Aaron Boodman, mihaip-chromium-reviews_chromium.org
Base URL:
http://git.chromium.org/chromium/src.git@master
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 2

Patch Set 2 : break long line #

Patch Set 3 : sync up #

Patch Set 4 : sigh #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -1 line) Patch
M chrome/browser/extensions/extension_service_unittest.cc View 1 2 3 1 chunk +9 lines, -1 line 0 comments Download

Messages

Total messages: 6 (0 generated)
eroman
8 years, 3 months ago (2012-08-29 18:53:02 UTC) #1
sreeram
lgtm http://codereview.chromium.org/10885034/diff/1/chrome/browser/extensions/extension_service_unittest.cc File chrome/browser/extensions/extension_service_unittest.cc (right): http://codereview.chromium.org/10885034/diff/1/chrome/browser/extensions/extension_service_unittest.cc#newcode2086 chrome/browser/extensions/extension_service_unittest.cc:2086: #define MAYBE_InstallAppsWithUnlimitedStorage DISABLED_InstallAppsWithUnlimitedStorage Break line here to stay ...
8 years, 3 months ago (2012-08-29 18:54:56 UTC) #2
eroman
http://codereview.chromium.org/10885034/diff/1/chrome/browser/extensions/extension_service_unittest.cc File chrome/browser/extensions/extension_service_unittest.cc (right): http://codereview.chromium.org/10885034/diff/1/chrome/browser/extensions/extension_service_unittest.cc#newcode2086 chrome/browser/extensions/extension_service_unittest.cc:2086: #define MAYBE_InstallAppsWithUnlimitedStorage DISABLED_InstallAppsWithUnlimitedStorage On 2012/08/29 18:54:56, sreeram wrote: > ...
8 years, 3 months ago (2012-08-29 18:56:56 UTC) #3
commit-bot: I haz the power
No LGTM from a valid reviewer yet. Only full committers are accepted. Even if an ...
8 years, 3 months ago (2012-08-29 19:10:29 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/eroman@chromium.org/10885034/4001
8 years, 3 months ago (2012-08-29 19:12:06 UTC) #5
commit-bot: I haz the power
8 years, 3 months ago (2012-08-29 21:00:45 UTC) #6
Try job failure for 10885034-4001 (retry) on linux_rel for step
"interactive_ui_tests".
It's a second try, previously, steps "interactive_ui_tests, unit_tests" failed.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_rel&...

Powered by Google App Engine
This is Rietveld 408576698