compiler/java/com/google/dart/compiler/resolver/MemberBuilder.java - Issue 10885031: Issue 3968. Support for redirecting factory constructors

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: compiler/java/com/google/dart/compiler/resolver/MemberBuilder.java

Issue 10885031: Issue 3968. Support for redirecting factory constructors (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Created 8 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « compiler/java/com/google/dart/compiler/ast/DartToSourceVisitor.java ('k') | compiler/java/com/google/dart/compiler/resolver/Resolver.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: compiler/java/com/google/dart/compiler/resolver/MemberBuilder.java

diff --git a/compiler/java/com/google/dart/compiler/resolver/MemberBuilder.java b/compiler/java/com/google/dart/compiler/resolver/MemberBuilder.java

index 7c9b55be3a3a163040f398f3933a786b0d372ebd..6f5280992e3b27e91f10e87ca12ccbf23fd5045f 100644

--- a/compiler/java/com/google/dart/compiler/resolver/MemberBuilder.java

+++ b/compiler/java/com/google/dart/compiler/resolver/MemberBuilder.java

@@ -8,8 +8,6 @@ import com.google.common.annotations.VisibleForTesting;

import com.google.common.base.Objects;

import com.google.dart.compiler.DartCompilerContext;

import com.google.dart.compiler.ErrorCode;

-import com.google.dart.compiler.PackageLibraryManager;

-import com.google.dart.compiler.Source;

import com.google.dart.compiler.ast.ASTVisitor;

import com.google.dart.compiler.ast.DartBlock;

import com.google.dart.compiler.ast.DartClass;

@@ -584,9 +582,10 @@ public class MemberBuilder {

if (modifiers.isFactory()) {

if (modifiers.isConstant()) {

- // Allow const factory ... native ... ; type of constructors, used in core libraries

+ // Allow const factory ... native ... ; type of constructors, used in core libraries.

+ // Allow const factory redirecting.

DartBlock dartBlock = method.getFunction().getBody();

- if (dartBlock == null || !(dartBlock instanceof DartNativeBlock)) {

+ if (!(dartBlock instanceof DartNativeBlock || method.getRedirectedTypeName() != null)) {

resolutionError(method.getName(), ResolverErrorCode.FACTORY_CANNOT_BE_CONST);

}