Issue 3968. Support for redirecting factory constructors

compiler/javatests/com/google/dart/compiler/type/TypeAnalyzerCompilerTest.java

 // Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 package com.google.dart.compiler.type;
 
 import static com.google.dart.compiler.common.ErrorExpectation.assertErrors;
 import static com.google.dart.compiler.common.ErrorExpectation.errEx;
 
 import com.google.common.base.Joiner;
 import com.google.common.collect.Iterables;
@@ skipping 18 matching lines @@
 import com.google.dart.compiler.ast.DartFieldDefinition;
 import com.google.dart.compiler.ast.DartForInStatement;
 import com.google.dart.compiler.ast.DartFunctionExpression;
 import com.google.dart.compiler.ast.DartIdentifier;
 import com.google.dart.compiler.ast.DartInvocation;
 import com.google.dart.compiler.ast.DartMapLiteralEntry;
 import com.google.dart.compiler.ast.DartMethodDefinition;
 import com.google.dart.compiler.ast.DartNewExpression;
 import com.google.dart.compiler.ast.DartNode;
 import com.google.dart.compiler.ast.DartParameter;
+import com.google.dart.compiler.ast.DartTypeNode;
 import com.google.dart.compiler.ast.DartUnit;
 import com.google.dart.compiler.ast.DartUnqualifiedInvocation;
 import com.google.dart.compiler.common.SourceInfo;
 import com.google.dart.compiler.parser.ParserErrorCode;
 import com.google.dart.compiler.resolver.ClassElement;
+import com.google.dart.compiler.resolver.ClassNodeElement;
 import com.google.dart.compiler.resolver.Element;
 import com.google.dart.compiler.resolver.ElementKind;
 import com.google.dart.compiler.resolver.MethodElement;
 import com.google.dart.compiler.resolver.NodeElement;
 import com.google.dart.compiler.resolver.ResolverErrorCode;
 import com.google.dart.compiler.resolver.TypeErrorCode;
 
 import java.io.Reader;
 import java.io.StringReader;
 import java.net.URI;
@@ skipping 3996 matching lines @@
     AnalyzeLibraryResult libraryResult = analyzeLibrary(makeCode(
         "// filler filler filler filler filler filler filler filler filler filler",
         "class A {",
         "  A.foo() {}",
         "  foo() {}",
         "}"));
     assertErrors(
         libraryResult.getErrors(),
         errEx(ResolverErrorCode.CONSTRUCTOR_WITH_NAME_OF_MEMBER, 3, 3, 5));
   }
-  
+
   /**
    * <p>
    * http://code.google.com/p/dart/issues/detail?id=3904
    */
   public void test_reifiedClasses() throws Exception {
     AnalyzeLibraryResult libraryResult = analyzeLibrary(makeCode(
         "// filler filler filler filler filler filler filler filler filler filler",
         "class A {}",
         "process(x) {}",
         "main() {",
         "  process(A);",
         "}"));
     assertErrors(libraryResult.getErrors());
   }
 
+  /**
+   * TODO(scheglov)
+   * <p>
+   * http://code.google.com/p/dart/issues/detail?id=3968
+   */
+  public void test_redirectingFactoryConstructor() throws Exception {
+    AnalyzeLibraryResult libraryResult = analyzeLibrary(makeCode(
+        "// filler filler filler filler filler filler filler filler filler filler",
+        "class A {",
+        "  A() {}",
+        "  A.named() {}",
+        "}",
+        "",
+        "class B {",
+        "  factory B.foo() = A;",
+        "  factory B.bar() = A.named;",
+        "}",
+        ""));
+    assertErrors(libraryResult.getErrors());
+    // prepare "class A"
+    ClassElement elementA = findNode(DartClass.class, "class A").getElement();
+    Type typeA = elementA.getType();
+    // = A;
+    {
+      DartTypeNode typeNode = findNode(DartTypeNode.class, "A;");
+      Type type = typeNode.getType();
+      assertSame(typeA, type);
+    }
+    // = A.named;
+    {
+      DartTypeNode typeNode = findNode(DartTypeNode.class, "A.named;");
+      Type type = typeNode.getType();
+      assertSame(typeA, type);
+      // .named
+      DartIdentifier nameNode = findNode(DartIdentifier.class, "named;");
+      NodeElement nameElement = nameNode.getElement();
+      assertNotNull(nameElement);
+      assertSame(elementA.lookupConstructor("named"), nameElement);
+    }
+  }
+  
+  public void test_redirectingFactoryConstructor_notConst_fromConst() throws Exception {
+    AnalyzeLibraryResult libraryResult = analyzeLibrary(makeCode(
+        "// filler filler filler filler filler filler filler filler filler filler",
+        "class A {",
+        "  A.named() {}",
+        "}",
+        "",
+        "class B {",
+        "  const factory B.bar() = A.named;",
+        "}",
+        ""));
+    assertErrors(
+        libraryResult.getErrors(),
+        errEx(ResolverErrorCode.REDIRECTION_CONSTRUCTOR_TARGET_MUST_BE_CONST, 7, 29, 5));
+  }
+
   private <T extends DartNode> T findNode(final Class<T> clazz, String pattern) {
     final int index = testSource.indexOf(pattern);
     assertTrue(index != -1);
     final AtomicReference<T> result = new AtomicReference<T>();
     testUnit.accept(new ASTVisitor<Void>() {
       @Override
       @SuppressWarnings("unchecked")
       public Void visitNode(DartNode node) {
         SourceInfo sourceInfo = node.getSourceInfo();
         if (sourceInfo.getOffset() <= index
             && index < sourceInfo.getEnd()
             && clazz.isInstance(node)) {
           result.set((T) node);
         }
         return super.visitNode(node);
       }
     });
     return result.get();
   }
 }