Issue 10885028: Revert 153817 - views: Add a gyp file to build webview.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10885028: Revert 153817 - views: Add a gyp file to build webview. (Closed)

Created:
8 years, 3 months ago by jochen (gone - plz use gerrit)

Modified:
8 years, 3 months ago

Reviewers:
tfarina

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

More Reviews

Description

Revert 153817 - views: Add a gyp file to build webview. BUG=105557 R=ben@chromium.org Review URL: https://chromiumcodereview.appspot.com/10882064 TBR=tfarina@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=153876

Patch Set 1 #

Created: 8 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -29 lines)			Patch
	M	build/all.gyp	View		1 chunk	+1 line, -2 lines	0 comments	Download
	D	ui/views/controls/webview/webview.gyp	View		1 chunk	+0 lines, -27 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

jochen (gone - plz use gerrit)

the gyp file probably needs to define VIEWS_IMPLEMENTATION or something, otherwise a component build on ...

8 years, 3 months ago (2012-08-29 11:17:15 UTC) #2

tfarina

8 years, 3 months ago (2012-08-30 01:04:37 UTC) #3

On 2012/08/29 11:17:15, jochen wrote:
> the gyp file probably needs to define VIEWS_IMPLEMENTATION or something,
> otherwise a component build on windows breaks since the symbols are declared
as
> imports but the cc file defines them

ok, will reland with those fix.

Expand Messages | Collapse Messages