Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(41)

Issue 10885027: Merge 126959 - style->fontMetrics() should be available when setting line-height (Closed)

Created:
8 years, 3 months ago by bashi
Modified:
8 years, 3 months ago
Reviewers:
bashi
CC:
chromium-reviews
Base URL:
http://svn.webkit.org/repository/webkit/branches/chromium/1229/
Visibility:
Public.

Description

Merge 126959 - style->fontMetrics() should be available when setting line-height https://bugs.webkit.org/show_bug.cgi?id=93327 Reviewed by Darin Adler. Source/WebCore: Setting line-height assumes the fontMetrics are available for the affected font, but the fontMetrics won't be available immediately after setting other properties like font-size. Call styleResolver->updateFont() before setting line-height to update fontMetrics. Added a test case to fast/canvas/crash-set-font.html. * html/canvas/CanvasRenderingContext2D.cpp: (WebCore::CanvasRenderingContext2D::setFont): Call styleResolver->updateFont() before styleResolver->applyPropertyToCurrentStyle(CSSPropertyLineHeight,...) LayoutTests: * fast/canvas/crash-set-font.html: Add a test case that sets both font-size and line-height. TBR=bashi@chromium.org Committed: https://trac.webkit.org/changeset/126978

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -2 lines) Patch
M LayoutTests/fast/canvas/crash-set-font.html View 1 chunk +1 line, -0 lines 0 comments Download
M Source/WebCore/html/canvas/CanvasRenderingContext2D.cpp View 1 chunk +3 lines, -2 lines 0 comments Download

Messages

Total messages: 1 (0 generated)
bashi
8 years, 3 months ago (2012-08-29 10:25:59 UTC) #1

          

Powered by Google App Engine
This is Rietveld 408576698