Integrate Chrome To Mobile with Action Box UI.

Integrate Chrome To Mobile with Action Box UI.

Gate IsChromeToMobileEnabled on Action Box flag.
Nix commandline flags, and about:flags entry.
Nix IDS_FLAGS_[EN|DIS]ABLE_CHROME_TO_MOBILE_[NAME|DESCRIPTION].

Remove page action icons, anchor to action box button:
Nix chrome_to_mobile_decoration.[h|mm] and use.
Nix chrome_to_mobile_view.[h|cc] and use.
Nix LocationBarViewGtk::CreateChromeToMobileButton, etc.
Nix Command observation from LocationBarView[Mac|Gtk|<win>].
Nix chromeToMobileBubblePoint, GetChromeToMobileBubblePoint, etc.
Nix SetChromeToMobileDecorationLit, VIEW_ID_CHROME_TO_MOBILE_BUTTON, etc.
Add SetActionBoxIcon, call from bubble show/close.
Revise SetTextButtonIconToId for TextButton anchor view.

Disable ShowChromeToMobileBubble on GTK :(

TODO(followup): Refine updating/observation of IDC_CHROME_TO_MOBILE_PAGE.
TODO(followup): TBD GTK Action Box, fallback UI, or more cleanup.

BUG=102709, 120905, 125307
TEST=Chrome To Mobile is enabled iff Action Box is enabled; disabled on GTK.

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=154120

[msw, 2012-08-29 22:01:54]

Please take a look, thanks!
Sail: chrome/browser/ui/cocoa/*
Erg: chrome/browser/ui/gtk/*
Sky: chrome/browser/ui/views/* and remainder :)

[Elliot Glaysher, 2012-08-29 22:10:09]

gtk rip out lgtm

[sail, 2012-08-29 22:29:51]

cocoa/* LGTM!

https://chromiumcodereview.appspot.com/10885024/diff/43/chrome/browser/ui/coc...
File chrome/browser/ui/cocoa/browser_window_controller.mm (left):

https://chromiumcodereview.appspot.com/10885024/diff/43/chrome/browser/ui/coc...
chrome/browser/ui/cocoa/browser_window_controller.mm:1671:
object:[chromeToMobileBubbleController_ window]];
can you add a DCHECK() for window. If this is ever nil we'll get notifications
for all windows

actually, i think it would be even better to do this within
-[ChromeToMobileBubbleController showWindow:] and
-[ChromeToMobileBubbleController windowWillClose].

You're already using BrowserWindowController in that code so it should be easy
to switch.

https://chromiumcodereview.appspot.com/10885024/diff/43/chrome/browser/ui/coc...
chrome/browser/ui/cocoa/browser_window_controller.mm:1683:
object:[chromeToMobileBubbleController_ window]];
same, need DCHECK

https://chromiumcodereview.appspot.com/10885024/diff/43/chrome/browser/ui/coc...
File chrome/browser/ui/cocoa/location_bar/location_bar_view_mac.h (right):

https://chromiumcodereview.appspot.com/10885024/diff/43/chrome/browser/ui/coc...
chrome/browser/ui/cocoa/location_bar/location_bar_view_mac.h:91: void
SetActionBoxIcon(int image_id);
would it make sense to add this to the base LocationBar class?

[msw, 2012-08-29 23:11:57]

Done. Scott, please take a look, thanks!

https://chromiumcodereview.appspot.com/10885024/diff/43/chrome/browser/ui/coc...
File chrome/browser/ui/cocoa/browser_window_controller.mm (left):

https://chromiumcodereview.appspot.com/10885024/diff/43/chrome/browser/ui/coc...
chrome/browser/ui/cocoa/browser_window_controller.mm:1671:
object:[chromeToMobileBubbleController_ window]];
On 2012/08/29 22:29:51, sail wrote:
> can you add a DCHECK() for window. If this is ever nil we'll get notifications
> for all windows
> 
> actually, i think it would be even better to do this within
> -[ChromeToMobileBubbleController showWindow:] and
> -[ChromeToMobileBubbleController windowWillClose].
> 
> You're already using BrowserWindowController in that code so it should be easy
> to switch.

Done (moved to ChromeToMobileBubbleController showWindow).

https://chromiumcodereview.appspot.com/10885024/diff/43/chrome/browser/ui/coc...
chrome/browser/ui/cocoa/browser_window_controller.mm:1683:
object:[chromeToMobileBubbleController_ window]];
On 2012/08/29 22:29:51, sail wrote:
> same, need DCHECK

Done (moved to ChromeToMobileBubbleController windowWillClose).

https://chromiumcodereview.appspot.com/10885024/diff/43/chrome/browser/ui/coc...
File chrome/browser/ui/cocoa/location_bar/location_bar_view_mac.h (right):

https://chromiumcodereview.appspot.com/10885024/diff/43/chrome/browser/ui/coc...
chrome/browser/ui/cocoa/location_bar/location_bar_view_mac.h:91: void
SetActionBoxIcon(int image_id);
On 2012/08/29 22:29:51, sail wrote:
> would it make sense to add this to the base LocationBar class?

LocationBar is just a pure virtual interface and Views/GTK don't do this the
same way / at all (at the moment), so I'll leave it as-is for now.

[sail, 2012-08-29 23:15:03]

lgtm

https://chromiumcodereview.appspot.com/10885024/diff/15001/chrome/browser/ui/...
File chrome/browser/ui/cocoa/chrome_to_mobile_bubble_controller.mm (right):

https://chromiumcodereview.appspot.com/10885024/diff/15001/chrome/browser/ui/...
chrome/browser/ui/cocoa/chrome_to_mobile_bubble_controller.mm:94: if (controller
!= nil) {
you don't need this check, message calls to nil are no-ops

[msw, 2012-08-29 23:26:19]

Done. Scott, please take a look; thanks!

https://chromiumcodereview.appspot.com/10885024/diff/15001/chrome/browser/ui/...
File chrome/browser/ui/cocoa/chrome_to_mobile_bubble_controller.mm (right):

https://chromiumcodereview.appspot.com/10885024/diff/15001/chrome/browser/ui/...
chrome/browser/ui/cocoa/chrome_to_mobile_bubble_controller.mm:94: if (controller
!= nil) {
On 2012/08/29 23:15:03, sail wrote:
> you don't need this check, message calls to nil are no-ops

Done.

[sky, 2012-08-30 00:33:15]

LGTM

[commit-bot: I haz the power, 2012-08-30 00:42:39]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/msw@chromium.org/10885024/46

[commit-bot: I haz the power, 2012-08-30 02:41:19]

Try job failure for 10885024-46 (retry) on linux_rel for step
"interactive_ui_tests".
It's a second try, previously, step "interactive_ui_tests" failed.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_rel&...

[msw, 2012-08-30 02:46:10]

The failures differ between runs (flakes?), trying again.

[commit-bot: I haz the power, 2012-08-30 02:46:29]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/msw@chromium.org/10885024/46

[commit-bot: I haz the power, 2012-08-30 04:14:31]

Try job failure for 10885024-46 (retry) on win for step "compile" (clobber
build).
It's a second try, previously, step "compile" failed.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win&number...

[commit-bot: I haz the power, 2012-08-30 05:10:42]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/msw@chromium.org/10885024/46

[commit-bot: I haz the power, 2012-08-30 07:15:33]

Try job failure for 10885024-46 (retry) (retry) on mac_rel for step
"sync_integration_tests".
It's a second try, previously, step "sync_integration_tests" failed.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=mac_rel&nu...

[commit-bot: I haz the power, 2012-08-30 07:56:30]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/msw@chromium.org/10885024/46

[commit-bot: I haz the power, 2012-08-30 13:03:23]

Change committed as 154120