Fix for failing unit tests PasswordStoreDefaultTest.*

chrome/browser/password_manager/password_form_data.cc

Index: chrome/browser/password_manager/password_form_data.cc
diff --git a/chrome/browser/password_manager/password_form_data.cc b/chrome/browser/password_manager/password_form_data.cc
index b919770efc1f8d166beb72e9e6cc5b9f85ee2008..decd520ea8be476d91f2b559a54c5f91d91b69ed 100644
--- a/chrome/browser/password_manager/password_form_data.cc
+++ b/chrome/browser/password_manager/password_form_data.cc
@@ -76,7 +76,9 @@ bool ContainsSamePasswordFormsPtr(
     const std::vector<PasswordForm*>& second) {
   if (first.size() != second.size())
     return false;
-  SetOfForms expectations(first.begin(), first.end());
+  SetOfForms expectations;
+  std::copy(first.begin(), first.end(), std::inserter(expectations,
+                                                      expectations.begin()));

[Ilya Sherman, 2012/08/29 22:53:51]

nit: Please add a comment documenting why this is written in this more complex
way.

[Ramya, 2012/08/29 23:01:34]

Done.

   for (unsigned int i = 0; i < second.size(); ++i) {
     const PasswordForm* actual = second[i];
     bool found_match = false;