Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(735)

Issue 10885016: Collect histograms from Plugins and GPU processes child processes only (Closed)

Created:
8 years, 3 months ago by ramant (doing other things)
Modified:
8 years, 3 months ago
CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, Nick Bray (chromium)
Visibility:
Public.

Description

Enable collecting histograms from Plugins and GPU processes only. Will enable other process types after testing them. R=jar,jam@chromium.org,sky BUG=145294 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=154501

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -1 line) Patch
M content/browser/histogram_controller.h View 1 1 chunk +3 lines, -1 line 0 comments Download
M content/browser/histogram_controller.cc View 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 13 (0 generated)
ramant (doing other things)
8 years, 3 months ago (2012-08-28 20:55:36 UTC) #1
jar (doing other things)
LGTM You probably should add to the bug that NACL was inconsistently pumping its IO ...
8 years, 3 months ago (2012-08-28 21:40:49 UTC) #2
ramant (doing other things)
Hi sky, Would appreciate OWNERS stamp please. thanks raman
8 years, 3 months ago (2012-08-28 22:20:05 UTC) #3
sky
You've got John as a reviewer, you don't need me.
8 years, 3 months ago (2012-08-28 22:53:52 UTC) #4
Nick Bray (chromium)
Ping: this is blocking http://codereview.chromium.org/10825462/
8 years, 3 months ago (2012-08-29 23:50:26 UTC) #5
jar (doing other things)
On 2012/08/29 23:50:26, Nick Bray (chromium) wrote: > Ping: this is blocking http://codereview.chromium.org/10825462/ I think ...
8 years, 3 months ago (2012-08-30 00:04:17 UTC) #6
Nick Bray
> I think you meant to say that you were waiting for jam@ to review. ...
8 years, 3 months ago (2012-08-30 00:10:09 UTC) #7
sky
LGTM
8 years, 3 months ago (2012-08-30 20:24:14 UTC) #8
ramant (doing other things)
On 2012/08/30 20:24:14, sky wrote: > LGTM Many many thanks sky. Sincerely appreciating it. -raman
8 years, 3 months ago (2012-08-30 20:51:23 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rtenneti@chromium.org/10885016/7001
8 years, 3 months ago (2012-08-30 20:51:50 UTC) #10
commit-bot: I haz the power
Try job failure for 10885016-7001 (retry) on linux_rel for step "interactive_ui_tests". It's a second try, ...
8 years, 3 months ago (2012-08-30 23:05:13 UTC) #11
jam
sorry just saw this. feel free to ping me over IM if i miss a ...
8 years, 3 months ago (2012-08-30 23:11:11 UTC) #12
commit-bot: I haz the power
8 years, 3 months ago (2012-08-31 17:59:28 UTC) #13

Powered by Google App Engine
This is Rietveld 408576698