Issue 10885002: Disable DCHECKs in non-official release builds on Android.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10885002: Disable DCHECKs in non-official release builds on Android. (Closed)

Created:
8 years, 3 months ago by Xianzhu

Modified:
8 years, 3 months ago

Reviewers:
Yaron, Isaac (away), nilesh, Paweł Hajdan Jr.

CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, erikwright+watch_chromium.org, jam, brettw-cc_chromium.org

Base URL:
ssh://gerrit-int.chromium.org:29419/clank/chromium@master

Visibility:
Public.

Disable DCHECKs in non-official release builds on Android. This is to better match tests expectations on other platforms. This should have been modified when switching default build from Release to Debug. I thought defining NDEBUG was enough to disable DCHECKs (though it really improves the performance of Release build because of other debug code disabled.) Change-Id: I16f346d73a6bcc0fe5a1c18d040d7dd184b37e2f R=yfriedman@chromium.org,ilevy@chromium.org,nileshagrawal@chromium.org TBR=phajdan.jr@chromium.org BUG=none Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=153810

Created: 8 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -2 lines)			Patch
	M	base/test/test_support_android.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
	M	content/app/android/library_loader_hooks.cc	View		1 chunk	+1 line, -1 line	0 comments	Download

Total messages: 5 (0 generated)

LGTM