Source/web/WebAXObject.cpp - Issue 1088473002: Refactor ScopedAXObjectCache to remove ref count

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/web/WebAXObject.cpp

Issue 1088473002: Refactor ScopedAXObjectCache to remove ref count (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: removed m_ownedCache init Created 5 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/web/WebAXObject.cpp

diff --git a/Source/web/WebAXObject.cpp b/Source/web/WebAXObject.cpp

index 92be6de0e4d73a47af21c8f07de6fb52c2778158..f5460c3ed24a8e5ce962022210082948d7eafd8e 100644

--- a/Source/web/WebAXObject.cpp

+++ b/Source/web/WebAXObject.cpp

@@ -76,15 +76,10 @@ static bool isLayoutClean(Document* document)

#endif

WebScopedAXContext::WebScopedAXContext(WebDocument& rootDocument)

- : m_private(adoptRef(new ScopedAXObjectCache(*rootDocument.unwrap<Document>())))

+ : m_private(ScopedAXObjectCache::create(*rootDocument.unwrap<Document>()))

{

}

-WebScopedAXContext::~WebScopedAXContext()

- m_private.reset();

WebAXObject WebScopedAXContext::root() const

{

return WebAXObject(static_cast<AXObjectCacheImpl*>(m_private->get())->root());