Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(94)

Side by Side Diff: Source/core/dom/Document.cpp

Issue 1088473002: Refactor ScopedAXObjectCache to remove ref count (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: removed m_ownedCache init Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « Source/core/dom/AXObjectCache.cpp ('k') | Source/core/dom/Element.cpp » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org) 2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org)
3 * (C) 1999 Antti Koivisto (koivisto@kde.org) 3 * (C) 1999 Antti Koivisto (koivisto@kde.org)
4 * (C) 2001 Dirk Mueller (mueller@kde.org) 4 * (C) 2001 Dirk Mueller (mueller@kde.org)
5 * (C) 2006 Alexey Proskuryakov (ap@webkit.org) 5 * (C) 2006 Alexey Proskuryakov (ap@webkit.org)
6 * Copyright (C) 2004, 2005, 2006, 2007, 2008, 2009, 2011, 2012 Apple Inc. All r ights reserved. 6 * Copyright (C) 2004, 2005, 2006, 2007, 2008, 2009, 2011, 2012 Apple Inc. All r ights reserved.
7 * Copyright (C) 2008, 2009 Torch Mobile Inc. All rights reserved. (http://www.t orchmobile.com/) 7 * Copyright (C) 2008, 2009 Torch Mobile Inc. All rights reserved. (http://www.t orchmobile.com/)
8 * Copyright (C) 2008, 2009, 2011, 2012 Google Inc. All rights reserved. 8 * Copyright (C) 2008, 2009, 2011, 2012 Google Inc. All rights reserved.
9 * Copyright (C) 2010 Nokia Corporation and/or its subsidiary(-ies) 9 * Copyright (C) 2010 Nokia Corporation and/or its subsidiary(-ies)
10 * Copyright (C) Research In Motion Limited 2010-2011. All rights reserved. 10 * Copyright (C) Research In Motion Limited 2010-2011. All rights reserved.
(...skipping 2217 matching lines...) Expand 10 before | Expand all | Expand 10 after
2228 // to any other WebCoreAXObject on the same page. Using a single cache allo ws 2228 // to any other WebCoreAXObject on the same page. Using a single cache allo ws
2229 // lookups across nested webareas (i.e. multiple documents). 2229 // lookups across nested webareas (i.e. multiple documents).
2230 Document& cacheOwner = this->axObjectCacheOwner(); 2230 Document& cacheOwner = this->axObjectCacheOwner();
2231 2231
2232 // If the document has already been detached, do not make a new axObjectCach e. 2232 // If the document has already been detached, do not make a new axObjectCach e.
2233 if (!cacheOwner.layoutView()) 2233 if (!cacheOwner.layoutView())
2234 return 0; 2234 return 0;
2235 2235
2236 ASSERT(&cacheOwner == this || !m_axObjectCache); 2236 ASSERT(&cacheOwner == this || !m_axObjectCache);
2237 if (!cacheOwner.m_axObjectCache) 2237 if (!cacheOwner.m_axObjectCache)
2238 cacheOwner.m_axObjectCache = adoptPtr(AXObjectCache::create(cacheOwner)) ; 2238 cacheOwner.m_axObjectCache = AXObjectCache::create(cacheOwner);
2239 return cacheOwner.m_axObjectCache.get(); 2239 return cacheOwner.m_axObjectCache.get();
2240 } 2240 }
2241 2241
2242 PassRefPtrWillBeRawPtr<DocumentParser> Document::createParser() 2242 PassRefPtrWillBeRawPtr<DocumentParser> Document::createParser()
2243 { 2243 {
2244 if (isHTMLDocument()) { 2244 if (isHTMLDocument()) {
2245 bool reportErrors = InspectorInstrumentation::collectingHTMLParseErrors( this); 2245 bool reportErrors = InspectorInstrumentation::collectingHTMLParseErrors( this);
2246 return HTMLDocumentParser::create(toHTMLDocument(*this), reportErrors, m _parserSyncPolicy); 2246 return HTMLDocumentParser::create(toHTMLDocument(*this), reportErrors, m _parserSyncPolicy);
2247 } 2247 }
2248 // FIXME: this should probably pass the frame instead 2248 // FIXME: this should probably pass the frame instead
(...skipping 3439 matching lines...) Expand 10 before | Expand all | Expand 10 after
5688 #ifndef NDEBUG 5688 #ifndef NDEBUG
5689 using namespace blink; 5689 using namespace blink;
5690 void showLiveDocumentInstances() 5690 void showLiveDocumentInstances()
5691 { 5691 {
5692 WeakDocumentSet& set = liveDocumentSet(); 5692 WeakDocumentSet& set = liveDocumentSet();
5693 fprintf(stderr, "There are %u documents currently alive:\n", set.size()); 5693 fprintf(stderr, "There are %u documents currently alive:\n", set.size());
5694 for (Document* document : set) 5694 for (Document* document : set)
5695 fprintf(stderr, "- Document %p URL: %s\n", document, document->url().str ing().utf8().data()); 5695 fprintf(stderr, "- Document %p URL: %s\n", document, document->url().str ing().utf8().data());
5696 } 5696 }
5697 #endif 5697 #endif
OLDNEW
« no previous file with comments | « Source/core/dom/AXObjectCache.cpp ('k') | Source/core/dom/Element.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698