Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(299)

Issue 10883076: Add explicit forwarding stubs for geometry classes cc uses (Closed)

Created:
8 years, 3 months ago by jamesr
Modified:
8 years, 3 months ago
Reviewers:
enne (OOO)
CC:
chromium-reviews
Visibility:
Public.

Description

Add explicit forwarding stubs for geometry classes cc uses libcc depends on several geometry types from WebCore - IntRect, FloatQuad, etc. We were picking these up by a header copying rule in the webkit_platform target that copies these headers into the generated build dir, but since there is no hard dependency link from libcc to webkit_platform this either work or not work depending on the exact build order on the user's system and was thus very fragile. This adds explicit forwarding headers which are ugly but at least will work. BUG= Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=153631

Patch Set 1 #

Total comments: 1

Patch Set 2 : fix bug linke #

Unified diffs Side-by-side diffs Delta from patch set Stats (+58 lines, -1 line) Patch
M cc/DEPS View 1 1 chunk +12 lines, -1 line 0 comments Download
A cc/stubs/FloatPoint.h View 1 chunk +5 lines, -0 lines 0 comments Download
A cc/stubs/FloatPoint3D.h View 1 chunk +5 lines, -0 lines 0 comments Download
A cc/stubs/FloatQuad.h View 1 chunk +6 lines, -0 lines 0 comments Download
A cc/stubs/FloatRect.h View 1 chunk +6 lines, -0 lines 0 comments Download
A cc/stubs/FloatSize.h View 1 chunk +6 lines, -0 lines 0 comments Download
A cc/stubs/IntPoint.h View 1 chunk +6 lines, -0 lines 0 comments Download
A cc/stubs/IntRect.h View 1 chunk +6 lines, -0 lines 0 comments Download
A cc/stubs/IntSize.h View 1 chunk +6 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
jamesr
8 years, 3 months ago (2012-08-28 00:36:02 UTC) #1
enne (OOO)
LGTM https://chromiumcodereview.appspot.com/10883076/diff/1/cc/DEPS File cc/DEPS (right): https://chromiumcodereview.appspot.com/10883076/diff/1/cc/DEPS#newcode13 cc/DEPS:13: # http://crbug.com/144542 144542 -> 144540
8 years, 3 months ago (2012-08-28 00:44:33 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jamesr@chromium.org/10883076/4001
8 years, 3 months ago (2012-08-28 01:04:13 UTC) #3
commit-bot: I haz the power
8 years, 3 months ago (2012-08-28 06:12:34 UTC) #4
Change committed as 153631

Powered by Google App Engine
This is Rietveld 408576698