Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(254)

Unified Diff: utils/pub/source.dart

Issue 10883072: Add a note to Source#install explaining that it should be very light-weight. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Review changes Created 8 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: utils/pub/source.dart
diff --git a/utils/pub/source.dart b/utils/pub/source.dart
index 839a20a38b618801003398af7631a4a434241d53..b879a5e9ea79ea103a23f0cc8086ebfa7a182142 100644
--- a/utils/pub/source.dart
+++ b/utils/pub/source.dart
@@ -103,6 +103,10 @@ class Source {
* [path] is guaranteed not to exist, and its parent directory is guaranteed
* to exist.
*
+ * Note that [path] may be deleted. If re-installing a package that has
+ * already been installed would be costly or impossible,
+ * [installToSystemCache] should be implemented instead of [install].
+ *
* This doesn't need to be implemented if [installToSystemCache] is
* implemented.
*/
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698