Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(464)

Unified Diff: runtime/vm/parser.cc

Issue 10883071: - Change "static final" to "static const" in the runtime/ directory. (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 8 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: runtime/vm/parser.cc
===================================================================
--- runtime/vm/parser.cc (revision 11416)
+++ runtime/vm/parser.cc (working copy)
@@ -2565,7 +2565,7 @@
if (has_initializer) {
ConsumeToken();
init_value = Object::sentinel();
- // For static final fields, the initialization expression
+ // For static const fields, the initialization expression
// will be parsed through the kConstImplicitGetter method
// invocation/compilation.
// For instance fields, the expression is parsed when a constructor
@@ -2590,7 +2590,7 @@
}
// Create the field object.
- // TODO(hausner): For now, all static final fields are constant. Remove
+ // TODO(hausner): For now, all static const fields are constant. Remove
hausner 2012/08/27 22:12:04 Please revert change in this comment.
Ivan Posva 2012/08/27 23:49:49 Mechanical replacement only works so far. Thanks f
// this when lazy init of static variables is implemented.
class_field = Field::New(*field->name,
field->has_static,
@@ -2602,7 +2602,7 @@
class_field.set_has_initializer(has_initializer);
members->AddField(class_field);
- // For static final fields, set value to "uninitialized" and
+ // For static const fields, set value to "uninitialized" and
// create a kConstImplicitGetter getter method.
if (field->has_static && has_initializer) {
class_field.set_value(init_value);

Powered by Google App Engine
This is Rietveld 408576698