Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(708)

Unified Diff: src/trusted/validator_ragel/unreviewed/validator_x86_64.rl

Issue 10883051: Add documentation for the dynamic code modifications. (Closed) Base URL: svn://svn.chromium.org/native_client/trunk/src/native_client/
Patch Set: Created 8 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/trusted/validator_ragel/unreviewed/validator_x86_32.rl ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/trusted/validator_ragel/unreviewed/validator_x86_64.rl
===================================================================
--- src/trusted/validator_ragel/unreviewed/validator_x86_64.rl (revision 9570)
+++ src/trusted/validator_ragel/unreviewed/validator_x86_64.rl (working copy)
@@ -29,7 +29,6 @@
}
action rel8_operand {
- instruction_info_collected |= RELATIVE_8BIT;
rel8_operand(current_position + 1, data, jump_dests, size,
&instruction_info_collected);
}
@@ -37,14 +36,14 @@
#error rel16_operand should never be used in nacl
}
action rel32_operand {
- instruction_info_collected |= RELATIVE_32BIT;
rel32_operand(current_position + 1, data, jump_dests, size,
&instruction_info_collected);
}
- action opcode_in_imm {
+ action last_byte_is_not_immediate {
instruction_info_collected |= LAST_BYTE_IS_NOT_IMMEDIATE;
}
+
action modifiable_instruction {
instruction_info_collected |= MODIFIABLE_INSTRUCTION;
}
@@ -372,8 +371,8 @@
BitmapSetBit(valid_targets, current_position - data);
}
@{
- if (instruction_info_collected & VALIDATION_ERRORS ||
- options & CALL_USER_CALLBACK_ON_EACH_INSTRUCTION) {
+ if ((instruction_info_collected & VALIDATION_ERRORS_MASK) ||
+ (options & CALL_USER_CALLBACK_ON_EACH_INSTRUCTION)) {
result &= user_callback(
instruction_start, current_position,
instruction_info_collected |
« no previous file with comments | « src/trusted/validator_ragel/unreviewed/validator_x86_32.rl ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698