Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(107)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 10883051: Add documentation for the dynamic code modifications. (Closed)

Created:
8 years, 3 months ago by khim
Modified:
8 years, 3 months ago
Reviewers:
halyavin
CC:
native-client-reviews_googlegroups.com
Visibility:
Public.

Description

Add documentation for the dynamic code modifications. Also change the names of the variables: include _MASK suffix in all masks. Committed: https://src.chromium.org/viewvc/native_client?view=rev&revision=9572

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Patch Set 4 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5624 lines, -4772 lines) Patch
M src/trusted/validator_ragel/gen/validator_x86_32.c View 1 2 3 197 chunks +2055 lines, -2041 lines 0 comments Download
M src/trusted/validator_ragel/gen/validator_x86_64.c View 853 chunks +2643 lines, -2618 lines 0 comments Download
M src/trusted/validator_ragel/unreviewed/dfa_validate_32.c View 1 2 3 6 chunks +7 lines, -7 lines 0 comments Download
M src/trusted/validator_ragel/unreviewed/dfa_validate_64.c View 1 2 3 6 chunks +13 lines, -9 lines 0 comments Download
A src/trusted/validator_ragel/unreviewed/files32.dot View 1 2 3 1 chunk +38 lines, -0 lines 0 comments Download
A src/trusted/validator_ragel/unreviewed/files32.svg View 1 2 3 1 chunk +161 lines, -0 lines 0 comments Download
A src/trusted/validator_ragel/unreviewed/files64.dot View 1 2 3 1 chunk +41 lines, -0 lines 0 comments Download
A src/trusted/validator_ragel/unreviewed/files64.svg View 1 2 3 1 chunk +178 lines, -0 lines 0 comments Download
A src/trusted/validator_ragel/unreviewed/filesdecoder.dot View 1 2 3 1 chunk +41 lines, -0 lines 0 comments Download
A src/trusted/validator_ragel/unreviewed/filesdecoder.svg View 1 2 3 1 chunk +188 lines, -0 lines 0 comments Download
M src/trusted/validator_ragel/unreviewed/gen_dfa.cc View 1 2 3 3 chunks +4 lines, -2 lines 0 comments Download
M src/trusted/validator_ragel/unreviewed/sample1.svg View 1 2 3 1 chunk +1 line, -2 lines 0 comments Download
M src/trusted/validator_ragel/unreviewed/sample2.svg View 1 2 3 1 chunk +1 line, -2 lines 0 comments Download
M src/trusted/validator_ragel/unreviewed/sample3.svg View 1 2 3 1 chunk +1 line, -2 lines 0 comments Download
M src/trusted/validator_ragel/unreviewed/validator.h View 1 2 3 3 chunks +5 lines, -3 lines 0 comments Download
M src/trusted/validator_ragel/unreviewed/validator_internal.h View 1 2 3 2 chunks +8 lines, -6 lines 0 comments Download
M src/trusted/validator_ragel/unreviewed/validator_internals.html View 1 2 3 6 chunks +231 lines, -69 lines 0 comments Download
M src/trusted/validator_ragel/unreviewed/validator_test.c View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M src/trusted/validator_ragel/unreviewed/validator_x86_32.rl View 1 2 3 3 chunks +3 lines, -5 lines 0 comments Download
M src/trusted/validator_ragel/unreviewed/validator_x86_64.rl View 1 2 3 3 chunks +4 lines, -5 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
khim
8 years, 3 months ago (2012-08-27 10:00:21 UTC) #1
halyavin
8 years, 3 months ago (2012-08-27 10:55:15 UTC) #2 
lgtm

Powered by Google App Engine
This is Rietveld 408576698