Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(825)

Issue 10883032: Merge 126540 - [chromium] Fix lost context when textures are evicted (Closed)

Created:
8 years, 4 months ago by piman
Modified:
8 years, 4 months ago
Reviewers:
piman
CC:
chromium-reviews
Base URL:
http://svn.webkit.org/repository/webkit/branches/chromium/1229/
Visibility:
Public.

Description

Merge 126540 - [chromium] Fix lost context when textures are evicted https://bugs.webkit.org/show_bug.cgi?id=94892 Reviewed by James Robinson. After eviction, the CCPrioritizedTextureManager is in a limbo state where all its resources are invalid. If we try to release them we will double-destroy them. New test: CCLayerTreeHostTestLostContextAfterEvictTextures. Source/WebCore: * platform/graphics/chromium/cc/CCThreadProxy.cpp: (WebCore::CCThreadProxy::recreateContextOnImplThread): Source/WebKit/chromium: * tests/CCLayerTreeHostTest.cpp: (CCLayerTreeHostTestLostContextAfterEvictTextures): (WTF::CCLayerTreeHostTestLostContextAfterEvictTextures::CCLayerTreeHostTestLostContextAfterEvictTextures): (WTF::CCLayerTreeHostTestLostContextAfterEvictTextures::beginTest): (EvictTexturesAndLoseContextTask): (WTF::CCLayerTreeHostTestLostContextAfterEvictTextures::EvictTexturesAndLoseContextTask::EvictTexturesAndLoseContextTask): (WTF::CCLayerTreeHostTestLostContextAfterEvictTextures::EvictTexturesAndLoseContextTask::~EvictTexturesAndLoseContextTask): (WTF::CCLayerTreeHostTestLostContextAfterEvictTextures::EvictTexturesAndLoseContextTask::run): (WTF::CCLayerTreeHostTestLostContextAfterEvictTextures::postEvictTexturesAndLoseContext): (WTF::CCLayerTreeHostTestLostContextAfterEvictTextures::didCommitAndDrawFrame): (WTF::CCLayerTreeHostTestLostContextAfterEvictTextures::commitCompleteOnCCThread): (WTF::CCLayerTreeHostTestLostContextAfterEvictTextures::didRecreateOutputSurface): (WTF::CCLayerTreeHostTestLostContextAfterEvictTextures::afterTest): (WTF): (WTF::TEST_F): TBR=piman@chromium.org Committed: https://trac.webkit.org/changeset/126623

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+98 lines, -2 lines) Patch
M Source/WebCore/platform/graphics/chromium/cc/CCSingleThreadProxy.cpp View 1 chunk +2 lines, -1 line 0 comments Download
M Source/WebCore/platform/graphics/chromium/cc/CCThreadProxy.cpp View 1 chunk +2 lines, -1 line 0 comments Download
M Source/WebKit/chromium/tests/CCLayerTreeHostTest.cpp View 2 chunks +94 lines, -0 lines 0 comments Download

Messages

Total messages: 1 (0 generated)
piman
8 years, 4 months ago (2012-08-24 21:22:28 UTC) #1

          

Powered by Google App Engine
This is Rietveld 408576698