Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(933)

Issue 10883026: Build the android_webview APKs on the Android FYI bot. (Closed)

Created:
8 years, 4 months ago by mkosiba (inactive)
Modified:
8 years, 3 months ago
CC:
chromium-reviews, android-webview-reviews_google.com
Visibility:
Public.

Description

Build the android_webview APKs on the FYI waterfall. This adds the android_webview APKs to the FYI build. This will result in building the android_webview Java code and Java test code. BUG= Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=153806

Patch Set 1 #

Patch Set 2 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -5 lines) Patch
M android_webview/java/src/org/chromium/android_webview/AwContentsClient.java View 1 1 chunk +0 lines, -5 lines 0 comments Download
M build/all_android.gyp View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (0 generated)
mkosiba (inactive)
8 years, 4 months ago (2012-08-24 16:22:41 UTC) #1
Peter Beverloo
Please run tryjobs and make sure they pass. We still have very decent cycle times, ...
8 years, 4 months ago (2012-08-24 16:37:35 UTC) #2
mkosiba (inactive)
On 2012/08/24 16:37:35, Peter Beverloo wrote: > Please run tryjobs and make sure they pass. ...
8 years, 4 months ago (2012-08-24 17:19:08 UTC) #3
Yaron
lgtm
8 years, 4 months ago (2012-08-24 17:20:08 UTC) #4
Isaac (away)
lgtm
8 years, 4 months ago (2012-08-24 17:36:22 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mkosiba@chromium.org/10883026/8001
8 years, 3 months ago (2012-08-28 20:51:08 UTC) #6
commit-bot: I haz the power
Presubmit check for 10883026-8001 failed and returned exit status 1. Running presubmit commit checks ...
8 years, 3 months ago (2012-08-28 20:51:15 UTC) #7
joth
lgtm
8 years, 3 months ago (2012-08-28 21:18:05 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mkosiba@chromium.org/10883026/8001
8 years, 3 months ago (2012-08-28 21:19:36 UTC) #9
commit-bot: I haz the power
8 years, 3 months ago (2012-08-29 00:18:50 UTC) #10
Change committed as 153806

Powered by Google App Engine
This is Rietveld 408576698