Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1496)

Unified Diff: chrome/browser/ui/views/extensions/extension_installed_bubble.cc

Issue 10883008: Port the Extension Install Bubble changes to Mac (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: Created 8 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/views/extensions/extension_installed_bubble.cc
===================================================================
--- chrome/browser/ui/views/extensions/extension_installed_bubble.cc (revision 153650)
+++ chrome/browser/ui/views/extensions/extension_installed_bubble.cc (working copy)
@@ -351,18 +351,16 @@
browser_(browser),
icon_(icon),
animation_wait_retries_(0) {
- if (extension->is_app()) {
+ if (extension->is_app())
type_ = APP;
- } else if (!extension_->omnibox_keyword().empty()) {
+ else if (!extension_->omnibox_keyword().empty())
type_ = OMNIBOX_KEYWORD;
- } else if (extension_->browser_action()) {
+ else if (extension_->browser_action())
type_ = BROWSER_ACTION;
- } else if (extension->page_action() &&
- !extension->page_action()->default_icon_path().empty()) {
+ else if (extension->page_action() && extension->is_verbose_install_message())
type_ = PAGE_ACTION;
- } else {
+ else
type_ = GENERIC;
- }
// |extension| has been initialized but not loaded at this point. We need
// to wait on showing the Bubble until not only the EXTENSION_LOADED gets
« no previous file with comments | « chrome/browser/ui/gtk/extensions/extension_installed_bubble_gtk.cc ('k') | chrome/common/extensions/extension.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698