Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(37)

Issue 10883003: Extracted parts of http://codereview.chromium.org/10875008/ that must be dcommitted separately. (Closed)

Created:
8 years, 4 months ago by robertshield
Modified:
8 years, 3 months ago
CC:
chromium-reviews, chrome-win8-eng_google.com
Visibility:
Public.

Description

Extracted parts of http://codereview.chromium.org/10875008/ that must be dcommitted separately. BUG=127799 TEST=NONE Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=155194

Patch Set 1 #

Patch Set 2 : Add OWNERS files. #

Patch Set 3 : Moving metro_driver files to /win8 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+21 lines, --4 lines) Patch
M DEPS View 2 chunks +1 line, -1 line 0 comments Download
A win8/OWNERS View 1 1 chunk +4 lines, -0 lines 0 comments Download
A win8/delegate_execute/delegate_execute.rc View 0 chunks +-1 lines, --1 lines 0 comments Download
A win8/metro_driver/DEPS View 1 2 1 chunk +5 lines, -0 lines 0 comments Download
A win8/metro_driver/resources/Logo.png View 1 2 0 chunks +-1 lines, --1 lines 0 comments Download
A win8/metro_driver/resources/SecondaryTile.png View 1 2 0 chunks +-1 lines, --1 lines 0 comments Download
A win8/metro_driver/resources/SmallLogo.png View 1 2 0 chunks +-1 lines, --1 lines 0 comments Download
A win8/metro_driver/resources/VisualElementsManifest.xml View 1 2 1 chunk +16 lines, -0 lines 0 comments Download
A win8/metro_driver/resources/splash-620x300.png View 1 2 0 chunks +-1 lines, --1 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
robertshield
This is the non-tryable part of patch http://codereview.chromium.org/10875008/. PTAL.
8 years, 4 months ago (2012-08-23 14:12:15 UTC) #1
cpu_(ooo_6.6-7.5)
lgtm
8 years, 4 months ago (2012-08-23 19:22:36 UTC) #2
robertshield
On 2012/08/23 19:22:36, cpu wrote: > lgtm @Ben: ping on this and http://codereview.chromium.org/10875008/
8 years, 3 months ago (2012-08-29 21:09:15 UTC) #3
robertshield
On 2012/08/29 21:09:15, robertshield wrote: > On 2012/08/23 19:22:36, cpu wrote: > > lgtm > ...
8 years, 3 months ago (2012-08-31 03:16:51 UTC) #4
Ben Goodger (Google)
8 years, 3 months ago (2012-08-31 19:46:41 UTC) #5
lgtm

Powered by Google App Engine
This is Rietveld 408576698