Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(79)

Issue 10882071: Fixes for bunch of browser tests that are trying to load content from file: schema. (Closed)

Created:
8 years, 3 months ago by zel
Modified:
8 years, 3 months ago
CC:
chromium-reviews, yoshiki+watch_chromium.org, cbentzel+watch_chromium.org, darin-cc_chromium.org
Visibility:
Public.

Description

Fixes for browser that load content from file: schema while running as ChromeOS BVTs on actual HW. This CL also fixes resource calculations in TaskManagerBrowserTest.* due to the fact that we also have GPU process present on ChromeOS side. TEST=TaskManagerBrowserTest.* and bunch of other browser tests should be passing now in BVT environment. BUG=131915 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=155243

Patch Set 1 #

Patch Set 2 : fixes #

Patch Set 3 : #

Patch Set 4 : #

Patch Set 5 : fixes #

Patch Set 6 : #

Patch Set 7 : #

Patch Set 8 : #

Patch Set 9 : #

Patch Set 10 : rebase #

Patch Set 11 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+146 lines, -93 lines) Patch
M chrome/browser/instant/instant_browsertest.cc View 1 2 3 4 5 6 7 8 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/net/chrome_network_delegate.cc View 1 2 3 4 5 6 7 8 9 10 3 chunks +6 lines, -1 line 0 comments Download
M chrome/browser/prerender/prerender_browsertest.cc View 1 2 3 4 5 6 7 8 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/task_manager/task_manager_browsertest.cc View 1 2 3 4 5 6 7 8 9 10 23 chunks +99 lines, -77 lines 0 comments Download
M chrome/browser/task_manager/task_manager_browsertest_util.h View 1 2 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/task_manager/task_manager_browsertest_util.cc View 1 2 3 4 5 6 7 8 5 chunks +26 lines, -3 lines 0 comments Download
M chrome/browser/task_manager/task_manager_notification_browsertest.cc View 1 2 3 4 5 6 2 chunks +5 lines, -5 lines 0 comments Download
M chrome/browser/ui/ash/caps_lock_handler.cc View 1 2 3 4 5 6 2 chunks +6 lines, -3 lines 0 comments Download

Messages

Total messages: 17 (0 generated)
zel
8 years, 3 months ago (2012-08-29 19:53:39 UTC) #1
sky
I don't know enough to say if the changes in chrome/browser/net are right. Everything else ...
8 years, 3 months ago (2012-08-29 21:11:16 UTC) #2
zel
+willchan as OWNER of chrome/browser/net/* part
8 years, 3 months ago (2012-08-29 21:17:52 UTC) #3
willchan no longer on Chromium
lgtm
8 years, 3 months ago (2012-08-29 23:32:48 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/zelidrag@chromium.org/10882071/12007
8 years, 3 months ago (2012-08-30 03:42:30 UTC) #5
commit-bot: I haz the power
Presubmit check for 10882071-12007 failed and returned exit status 1. Running presubmit commit checks ...
8 years, 3 months ago (2012-08-30 03:42:34 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/zelidrag@chromium.org/10882071/22001
8 years, 3 months ago (2012-08-30 17:29:05 UTC) #7
commit-bot: I haz the power
Try job failure for 10882071-22001 (retry) on linux_rel for step "browser_tests". It's a second try, ...
8 years, 3 months ago (2012-08-30 20:04:01 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/zelidrag@chromium.org/10882071/22001
8 years, 3 months ago (2012-08-30 20:19:22 UTC) #9
commit-bot: I haz the power
Try job failure for 10882071-22001 (retry) on linux_rel for step "browser_tests". It's a second try, ...
8 years, 3 months ago (2012-08-30 22:25:13 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/zelidrag@chromium.org/10882071/22001
8 years, 3 months ago (2012-08-31 21:12:42 UTC) #11
commit-bot: I haz the power
Try job failure for 10882071-22001 (retry) on linux_rel for step "browser_tests". It's a second try, ...
8 years, 3 months ago (2012-08-31 22:50:18 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/zelidrag@chromium.org/10882071/36002
8 years, 3 months ago (2012-09-06 02:44:23 UTC) #13
commit-bot: I haz the power
Failed to apply patch for chrome/browser/net/chrome_network_delegate.cc: While running patch -p1 --forward --force; patching file chrome/browser/net/chrome_network_delegate.cc ...
8 years, 3 months ago (2012-09-06 05:08:05 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/zelidrag@chromium.org/10882071/31012
8 years, 3 months ago (2012-09-06 16:59:44 UTC) #15
commit-bot: I haz the power
Try job failure for 10882071-31012 (retry) on mac_rel for step "sync_integration_tests". It's a second try, ...
8 years, 3 months ago (2012-09-06 18:39:17 UTC) #16
commit-bot: I haz the power
8 years, 3 months ago (2012-09-06 19:01:46 UTC) #17

Powered by Google App Engine
This is Rietveld 408576698