Issue 10882070: Simplify regex matching in build-deb.sh.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10882070: Simplify regex matching in build-deb.sh. (Closed)

Created:
8 years, 3 months ago by Sergey Ulanov

Modified:
8 years, 3 months ago

Reviewers:
Jamie

CC:
chromium-reviews, jamiewalch+watch_chromium.org, dcaiafa+watch_chromium.org, simonmorris+watch_chromium.org, hclam+watch_chromium.org, wez+watch_chromium.org, amit, sanjeevr, garykac+watch_chromium.org, lambroslambrou+watch_chromium.org, alexeypa+watch_chromium.org, sergeyu+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Simplify regex matching in build-deb.sh. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=153577

Patch Set 1 #

Total comments: 2

Patch Set 2 : #

Created: 8 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -2 lines)			Patch
	M	remoting/host/installer/linux/build-deb.sh	View	1	1 chunk	+1 line, -2 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Sergey Ulanov

Addressing comments from http://codereview.chromium.org/10872092/

8 years, 3 months ago (2012-08-27 21:22:52 UTC) #1

Jamie

lgtm with one minor change. http://codereview.chromium.org/10882070/diff/1/remoting/host/installer/linux/build-deb.sh File remoting/host/installer/linux/build-deb.sh (right): http://codereview.chromium.org/10882070/diff/1/remoting/host/installer/linux/build-deb.sh#newcode17 remoting/host/installer/linux/build-deb.sh:17: if [[ ! $version_full ...

8 years, 3 months ago (2012-08-27 22:39:54 UTC) #2

Sergey Ulanov

8 years, 3 months ago (2012-08-27 23:29:04 UTC) #3

http://codereview.chromium.org/10882070/diff/1/remoting/host/installer/linux/...
File remoting/host/installer/linux/build-deb.sh (right):

http://codereview.chromium.org/10882070/diff/1/remoting/host/installer/linux/...
remoting/host/installer/linux/build-deb.sh:17: if [[ ! $version_full =~
^[0-9]+\.[0-9]+\.[0-9]+\.[0-9]+$ ]]; then
On 2012/08/27 22:39:54, Jamie wrote:
> You should add quotes around "$version_full"

Done.

Expand Messages | Collapse Messages