Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4337)

Unified Diff: chrome/browser/captive_portal/captive_portal_service.cc

Issue 10882063: Captive portal service: Don't use a retry delay after getting a new result. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: Created 8 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/captive_portal/captive_portal_service_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/captive_portal/captive_portal_service.cc
===================================================================
--- chrome/browser/captive_portal/captive_portal_service.cc (revision 153076)
+++ chrome/browser/captive_portal/captive_portal_service.cc (working copy)
@@ -261,13 +261,17 @@
ResetBackoffEntry(new_result);
backoff_entry_->SetCustomReleaseTime(now + retry_after_delta);
- backoff_entry_->InformOfRequest(true);
+ // The BackoffEntry is not informed of this request, so there's no delay
+ // before the next request. This allows for faster login when a captive
+ // portal is first detected. It can also help when moving between captive
+ // portals.
} else {
DCHECK_LE(1, num_checks_with_same_result_);
++num_checks_with_same_result_;
// Requests that have the same Result as the last one are considered
// "failures", to trigger backoff.
+ backoff_entry_->SetCustomReleaseTime(now + retry_after_delta);
backoff_entry_->InformOfRequest(false);
}
« no previous file with comments | « no previous file | chrome/browser/captive_portal/captive_portal_service_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698