Add examples for showing how to use systemInfo API.

Add an example for showing how to use systemInfo API.

BUG=136519
TEST=None

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=153637

[Hongbo Min, 2012-08-27 15:15:22]

This is an extension example to facilitate the systemInfo API development and
test.

[Mihai Parparita -not on Chrome, 2012-08-27 23:47:21]

LGTM

http://codereview.chromium.org/10882059/diff/1/chrome/common/extensions/docs/...
File chrome/common/extensions/docs/examples/api/systemInfo/main.js (right):

http://codereview.chromium.org/10882059/diff/1/chrome/common/extensions/docs/...
chrome/common/extensions/docs/examples/api/systemInfo/main.js:8: var is_started
= false;
JavaScript naming conventions are to use camelCase.

http://codereview.chromium.org/10882059/diff/1/chrome/common/extensions/docs/...
chrome/common/extensions/docs/examples/api/systemInfo/main.js:45: table =
showStorageInfo(info.units[i], table);
Why make table a parameter, when you can just say table+=
getStorageInfoForUnit(unit)?

http://codereview.chromium.org/10882059/diff/1/chrome/common/extensions/docs/...
File chrome/common/extensions/docs/examples/api/systemInfo/manifest.json
(right):

http://codereview.chromium.org/10882059/diff/1/chrome/common/extensions/docs/...
chrome/common/extensions/docs/examples/api/systemInfo/manifest.json:2:
"version": "0.1",
Nit: use 2-space tabs.

http://codereview.chromium.org/10882059/diff/1/chrome/common/extensions/docs/...
chrome/common/extensions/docs/examples/api/systemInfo/manifest.json:6:
"description": "Show how to use SystemInfo API",
Make this a bit more descriptive and say "Shows disk capacity via the SystemInfo
API"?

[Hongbo Min, 2012-08-28 01:54:02]

http://codereview.chromium.org/10882059/diff/1/chrome/common/extensions/docs/...
File chrome/common/extensions/docs/examples/api/systemInfo/main.js (right):

http://codereview.chromium.org/10882059/diff/1/chrome/common/extensions/docs/...
chrome/common/extensions/docs/examples/api/systemInfo/main.js:8: var is_started
= false;
On 2012/08/27 23:47:21, Mihai Parparita wrote:
> JavaScript naming conventions are to use camelCase.

Done.

http://codereview.chromium.org/10882059/diff/1/chrome/common/extensions/docs/...
chrome/common/extensions/docs/examples/api/systemInfo/main.js:45: table =
showStorageInfo(info.units[i], table);
On 2012/08/27 23:47:21, Mihai Parparita wrote:
> Why make table a parameter, when you can just say table+=
> getStorageInfoForUnit(unit)?

Done.

http://codereview.chromium.org/10882059/diff/1/chrome/common/extensions/docs/...
File chrome/common/extensions/docs/examples/api/systemInfo/manifest.json
(right):

http://codereview.chromium.org/10882059/diff/1/chrome/common/extensions/docs/...
chrome/common/extensions/docs/examples/api/systemInfo/manifest.json:2:
"version": "0.1",
On 2012/08/27 23:47:21, Mihai Parparita wrote:
> Nit: use 2-space tabs.

Done.

http://codereview.chromium.org/10882059/diff/1/chrome/common/extensions/docs/...
chrome/common/extensions/docs/examples/api/systemInfo/manifest.json:6:
"description": "Show how to use SystemInfo API",
On 2012/08/27 23:47:21, Mihai Parparita wrote:
> Make this a bit more descriptive and say "Shows disk capacity via the
SystemInfo
> API"?

Done.

[commit-bot: I haz the power, 2012-08-28 01:54:20]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/hongbo.min@intel.com/10882059/6001

[commit-bot: I haz the power, 2012-08-28 01:54:23]

Presubmit check for 10882059-6001 failed and returned exit status 1.


Running presubmit commit checks ...

** Presubmit Warnings **
This change modifies the extension docs but the generated docs have not been
updated properly. See chrome/common/extensions/docs/README.txt for more info.
 - Changes to sample
chrome/common/extensions/docs/examples/api/systemInfo/index.html have not been
re-zipped.
 - Changes to sample
chrome/common/extensions/docs/examples/api/systemInfo/main.js have not been
re-zipped.
 - Changes to sample
chrome/common/extensions/docs/examples/api/systemInfo/manifest.json have not
been re-zipped.
First build DumpRenderTree, then update the docs by running:
  chrome/common/extensions/docs/build/build.py --page-name=<apiName>

[commit-bot: I haz the power, 2012-08-28 03:34:37]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/hongbo.min@intel.com/10882059/10001

[commit-bot: I haz the power, 2012-08-28 07:00:28]

Change committed as 153637

[vabr (Chromium), 2012-08-29 18:13:20]

On 2012/08/28 07:00:28, I haz the power (commit-bot) wrote:
> Change committed as 153637

Hi Hongbo Min,

It looks like in your commit the file
chrome/common/extensions/docs/examples/api/systemInfo.zip went in empty. This
breaks chrome/common/extensions/docs/build/build.py. (Workaround is to delete
the zip and let build.py regenerate it.)

Please commit the right systemInfo.zip.

Thanks,
Vaclav

[Mihai Parparita -not on Chrome, 2012-08-29 18:22:54]

I'm guessing that's due to the commit queue not handling binary files
correctly. Hongo is not a committer, so he can't commit those files
directly. I'll take care of it.

Mihai

On Wed, Aug 29, 2012 at 11:13 AM, <vabr@chromium.org> wrote:

> On 2012/08/28 07:00:28, I haz the power (commit-bot) wrote:
>
>> Change committed as 153637
>>
>
> Hi Hongbo Min,
>
> It looks like in your commit the file
> chrome/common/extensions/docs/**examples/api/systemInfo.zip went in
> empty. This
> breaks chrome/common/extensions/docs/**build/build.py. (Workaround is to
> delete
> the zip and let build.py regenerate it.)
>
> Please commit the right systemInfo.zip.
>
> Thanks,
> Vaclav
>
>
https://chromiumcodereview.**appspot.com/10882059/<https://chromiumcodereview...
>

[Mihai Parparita -not on Chrome, 2012-08-29 19:09:17]

Fixed with http://crrev.com/153935

Mihai

On Wed, Aug 29, 2012 at 11:22 AM, Mihai Parparita <mihaip@chromium.org>wrote:

> I'm guessing that's due to the commit queue not handling binary files
> correctly. Hongo is not a committer, so he can't commit those files
> directly. I'll take care of it.
>
> Mihai
>
>
> On Wed, Aug 29, 2012 at 11:13 AM, <vabr@chromium.org> wrote:
>
>> On 2012/08/28 07:00:28, I haz the power (commit-bot) wrote:
>>
>>> Change committed as 153637
>>>
>>
>> Hi Hongbo Min,
>>
>> It looks like in your commit the file
>> chrome/common/extensions/docs/**examples/api/systemInfo.zip went in
>> empty. This
>> breaks chrome/common/extensions/docs/**build/build.py. (Workaround is to
>> delete
>> the zip and let build.py regenerate it.)
>>
>> Please commit the right systemInfo.zip.
>>
>> Thanks,
>> Vaclav
>>
>>
https://chromiumcodereview.**appspot.com/10882059/<https://chromiumcodereview...
>>
>
>