Put live register bits in stackmaps.

runtime/vm/stack_frame.cc

 // Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 #include "vm/stack_frame.h"
 
 #include "vm/assembler_macros.h"
 #include "vm/isolate.h"
 #include "vm/object.h"
 #include "vm/object_store.h"
@@ skipping 46 matching lines @@
   RawObject** end_addr = reinterpret_cast<RawObject**>(fp()) +
       ParsedFunction::kFirstLocalSlotIndex;
   Code code;
   code = LookupDartCode();
   if (!code.IsNull()) {
     Array maps;
     maps = Array::null();
     Stackmap map;
     map = code.GetStackmap(pc(), &maps, &map);
     if (!map.IsNull()) {
-      // A stack map is present in the code object, use the stack map to visit
-      // frame slots which are marked as having objects.
+      // A stack map is present in the code object, use the stack map to
+      // visit frame slots which are marked as having objects.
+      //
+      // The layout of the frame is (lower addresses to the right):
+      // | spill slots | outgoing arguments | saved registers |
+      // |XXXXXXXXXXXXX|--------------------|XXXXXXXXXXXXXXXXX|
+      //
+      // The splill slots and any saved registers are described in the stack
+      // map.  The outgoing arguments are assumed to be tagged; the number
+      // of outgoing arguments is not explicitly tracked.
+      //
+      // TODO(kmillikin): This does not handle slow path calls with
+      // arguments, where the arguments are pushed after the live registers.
+      // Enable such calls.
       intptr_t length = map.Length();
-      for (intptr_t bit_index = 0; bit_index < length; ++bit_index) {
-        if (map.IsObject(bit_index)) {
-          visitor->VisitPointer(end_addr - bit_index);
-        }
+      // Spill slots are at the 'bottom' of the frame.
+      intptr_t spill_slot_count = length - map.RegisterBitCount();
+      for (intptr_t bit = 0; bit < spill_slot_count; ++bit) {
+        if (map.IsObject(bit)) visitor->VisitPointer(end_addr);
+        --end_addr;
       }
-      // The stack slots that are not spill slots (i.e., outgoing arguments)
-      // are tagged objects.
-      end_addr -= length;
+
+      // The live registers at the 'top' of the frame comprise the rest of the
+      // stack map.
+      for (intptr_t bit = length - 1; bit >= spill_slot_count; --bit) {
+        if (map.IsObject(bit)) visitor->VisitPointer(start_addr);
+        ++start_addr;
+      }
+
       // The end address can be one slot (but not more) past the start
       // address in the case that all slots were covered by the stack map.
       ASSERT((end_addr + 1) >= start_addr);
     }
   }
   // Each slot between the start and end address are tagged objects.
   visitor->VisitPointers(start_addr, end_addr);
 }
 
 
@@ skipping 156 matching lines @@
 EntryFrame* StackFrameIterator::NextEntryFrame() {
   ASSERT(!frames_.HasNext());
   entry_.sp_ = frames_.sp_;
   entry_.fp_ = frames_.fp_;
   SetupNextExitFrameData();  // Setup data for next exit frame in chain.
   ASSERT(entry_.IsValid());
   return &entry_;
 }
 
 }  // namespace dart