Put live register bits in stackmaps.

runtime/vm/flow_graph_compiler.cc

 // Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 #include "vm/globals.h"  // Needed here to get TARGET_ARCH_XXX.
 
 #include "vm/flow_graph_compiler.h"
 
 #include "vm/dart_entry.h"
 #include "vm/debugger.h"
 #include "vm/deopt_instructions.h"
+#include "vm/flow_graph_allocator.h"
 #include "vm/il_printer.h"
 #include "vm/intrinsifier.h"
 #include "vm/locations.h"
 #include "vm/longjump.h"
 #include "vm/object_store.h"
 #include "vm/parser.h"
 #include "vm/stub_code.h"
 #include "vm/symbols.h"
 
 namespace dart {
@@ skipping 223 matching lines @@
                                        deopt_id,
                                        token_pos,
                                        deopt_index);
 }
 
 
 void FlowGraphCompiler::RecordSafepoint(LocationSummary* locs) {
   if (is_optimizing()) {
     BitmapBuilder* bitmap = locs->stack_bitmap();
     ASSERT(bitmap != NULL);
+    ASSERT(bitmap->Length() <= StackSize());
+    // Pad the bitmap out to describe all the spill slots.
     bitmap->SetLength(StackSize());
-    stackmap_table_builder_->AddEntry(assembler()->CodeSize(), bitmap);
+
+    // Slow path code can have registers at the safepoint.
+    if (!locs->always_calls()) {
+      // Mark the bits in the stack map in the same order we push registers

[Vyacheslav Egorov (Google), 2012/08/30 09:24:35]

this does not actually match with that order: when we store xmm registers xmm0
comes at the top (if live), but here last one comes at the top.

[Kevin Millikin (Google), 2012/08/30 10:02:21]

You're right and it's a bit fishy.  I've made it match.

+      // in slow path code (see FlowGraphCompiler::SaveLiveRegisters).
+      RegisterSet* regs = locs->live_registers();
+      if (regs->xmm_regs_count() > 0) {
+        // Denote XMM registers  with 0 bits in the  stackmap.  Based on the
+        // assumption that  there are normally few live  XMM registers, this

[Vyacheslav Egorov (Google), 2012/08/30 09:24:35]

s/live  XMM/live XMM/

[Kevin Millikin (Google), 2012/08/30 10:02:21]

You don't like the fully justified comments?

+        // encoding is simpler and roughly  as compact as storing a separate
+        // count of XMM registers.
+        for (intptr_t i = 0; i < kNumberOfXmmRegisters; ++i) {
+          XmmRegister reg = static_cast<XmmRegister>(i);
+          if (regs->ContainsXmmRegister(reg)) {
+            for (intptr_t j = 0;
+                 j < FlowGraphAllocator::kDoubleSpillSlotFactor;
+                 ++j) {
+              bitmap->Set(bitmap->Length(), false);
+            }
+          }
+        }
+      }
+      for (intptr_t i = 0; i < kNumberOfCpuRegisters; ++i) {
+        Register reg = static_cast<Register>(i);
+        if (locs->live_registers()->ContainsRegister(reg)) {
+          bitmap->Set(bitmap->Length(), true);
+        }
+      }
+    }
+
+    intptr_t register_bit_count = bitmap->Length() - StackSize();
+    stackmap_table_builder_->AddEntry(assembler()->CodeSize(),
+                                      bitmap,
+                                      register_bit_count);
   }
 }
 
 
 Label* FlowGraphCompiler::AddDeoptStub(intptr_t deopt_id,
                                        DeoptReasonId reason) {
   DeoptimizationStub* stub = new DeoptimizationStub(deopt_id, reason);
   ASSERT(is_optimizing_);
   ASSERT(pending_deoptimization_env_ != NULL);
   stub->set_deoptimization_env(pending_deoptimization_env_);
@@ skipping 480 matching lines @@
       return;
     }
   }
 
   // This move is not blocked.
   EmitMove(index);
 }
 
 
 }  // namespace dart