Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3)

Issue 10882053: Fixed memory leak. (Closed)

Created:
8 years, 3 months ago by Vitaly Buka (NO REVIEWS)
Modified:
8 years, 3 months ago
Reviewers:
Albert Bodenhamer
CC:
chromium-reviews
Visibility:
Public.

Description

Fixed memory leak. PrintSystemTaskProxy needs UI thread to be deleted. BUG=144898 NOTRY=true Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=153508

Patch Set 1 : #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+31 lines, -29 lines) Patch
M chrome/browser/printing/print_system_task_proxy_unittest.cc View 1 7 chunks +31 lines, -7 lines 0 comments Download
M tools/heapcheck/suppressions.txt View 1 1 chunk +0 lines, -10 lines 0 comments Download
M tools/valgrind/memcheck/suppressions.txt View 1 1 chunk +0 lines, -12 lines 0 comments Download

Messages

Total messages: 18 (0 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/vitalybuka@chromium.org/10882053/3001
8 years, 3 months ago (2012-08-27 06:31:36 UTC) #1
Nico
On 2012/08/27 06:31:36, I haz the power (commit-bot) wrote: > CQ is trying da patch. ...
8 years, 3 months ago (2012-08-27 06:33:24 UTC) #2
Nico
On 2012/08/27 06:33:24, Nico wrote: > On 2012/08/27 06:31:36, I haz the power (commit-bot) wrote: ...
8 years, 3 months ago (2012-08-27 06:34:09 UTC) #3
Vitaly Buka (NO REVIEWS)
Ok. I just planed to remove in separate CL. On 2012/08/27 06:33:24, Nico wrote: > ...
8 years, 3 months ago (2012-08-27 06:34:48 UTC) #4
Vitaly Buka (NO REVIEWS)
Done
8 years, 3 months ago (2012-08-27 06:39:34 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/vitalybuka@chromium.org/10882053/8004
8 years, 3 months ago (2012-08-27 06:45:14 UTC) #6
commit-bot: I haz the power
Try job failure for 10882053-8004 on linux_chromeos for step "update". http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_chromeos&number=35303 Step "update" is always ...
8 years, 3 months ago (2012-08-27 06:46:40 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/vitalybuka@chromium.org/10882053/10003
8 years, 3 months ago (2012-08-27 06:50:04 UTC) #8
commit-bot: I haz the power
Try job failure for 10882053-10003 on linux_chromeos for step "update". http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_chromeos&number=35304 Step "update" is always ...
8 years, 3 months ago (2012-08-27 06:51:21 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/vitalybuka@chromium.org/10882053/10004
8 years, 3 months ago (2012-08-27 07:07:16 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/vitalybuka@chromium.org/10882053/4011
8 years, 3 months ago (2012-08-27 07:28:30 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/vitalybuka@chromium.org/10882053/4011
8 years, 3 months ago (2012-08-27 15:12:55 UTC) #12
Nico
Thanks for removing the suppressions, and also for addressing this quickly. I think if you ...
8 years, 3 months ago (2012-08-27 16:02:09 UTC) #13
Albert Bodenhamer
lgtm
8 years, 3 months ago (2012-08-27 16:09:09 UTC) #14
Vitaly Buka (NO REVIEWS)
Agree, TBR is not necessary here. On 2012/08/27 16:02:09, Nico wrote: > Thanks for removing ...
8 years, 3 months ago (2012-08-27 16:54:24 UTC) #15
commit-bot: I haz the power
Commit queue rejected this change because the description was changed between the time the change ...
8 years, 3 months ago (2012-08-27 17:36:50 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/vitalybuka@chromium.org/10882053/4011
8 years, 3 months ago (2012-08-27 18:12:42 UTC) #17
commit-bot: I haz the power
8 years, 3 months ago (2012-08-27 18:12:55 UTC) #18
Change committed as 153508

Powered by Google App Engine
This is Rietveld 408576698